fix(middleware-serde): add response metadata to deserialization errors #1588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddsriv
approved these changes
May 12, 2025
kuhe
commented
May 12, 2025
trivikr
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
error.$metadatafield to deserialization errors, so that the (earlier in order) retry middleware can decide to retry the error if the response code is retryable, regardless of the format of the error.This scenario can happen when a server origin response is supposed to be e.g. JSON but its load balancer is XML or does not reach the point of checking the correct response format. If the LB sheds a request with a retryable error code but unparsable body, the parsing error should be treated as non-terminal, retryable.