fix(website): correct pricing.astro Audit Logging/SIEM roadmap staleness#1998
Merged
Conversation
Website Preview
|
wrsmith108
force-pushed
the
fix/smi-5735-pricing-roadmap-audit
branch
from
July 21, 2026 02:53
5210ac6 to
21a9950
Compare
E2E Test Results
|
E2E Test ResultsE2E Test Results - July 21, 2026Summary
Test Results
Generated by skillsmith E2E test suite |
audit_export, audit_query, and siem_export are shipped, Enterprise-only gated MCP tools (toolFeatureMapping.ts: audit_logging -> 'enterprise'), not roadmap items. The Audit Logging comparison-table row was showing a roadmap clock instead of a check, and 'Audit logging (MCP tools)' / 'SIEM export' were listed as unshipped Enterprise roadmap bullets. Fixes the table row's Enterprise cell, adds a missing SIEM Export row (same Enterprise-only pattern, distinct from the Team+Enterprise Compliance Reports row), and removes the two now-inaccurate roadmap bullets. SSO/SAML and RBAC were verified separately as genuinely still-unshipped stub implementations and are left untouched. Refs SMI-5735, SMI-3140, SMI-5688 Co-Authored-By: claude-flow <ruv@ruv.net> Co-Authored-By: Claude <noreply@anthropic.com>
Refs SMI-5735 Co-Authored-By: claude-flow <ruv@ruv.net> Co-Authored-By: Claude <noreply@anthropic.com>
wrsmith108
force-pushed
the
fix/smi-5735-pricing-roadmap-audit
branch
from
July 21, 2026 04:40
21a9950 to
57ab019
Compare
E2E Test ResultsE2E Test Results - July 21, 2026Summary
Test Results
Generated by skillsmith E2E test suite |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Business Summary
What shipped:
packages/website/src/pages/pricing.astro's Enterprise "On the roadmap" list incorrectly showed Audit Logging and SIEM export as unshipped, and the comparison table's Audit Logging row showed a roadmap clock instead of a checkmark. Both are actually shipped, Enterprise-only gated MCP tools (audit_export,audit_query,siem_export) — verified directly againsttoolFeatureMapping.ts, not inferred. Fixed the table row, added the missing SIEM Export table row, and removed the two stale roadmap bullets.Quality bar:
astro checkclean (169 files, 0 errors/warnings/hints). Independent cross-provider review (Sol/Codex via NEEDLE) of the diff: PASS, 0 defects. Followed up on Sol's one recommendation (verify no other page text — JSON-LD, FAQ — still references these as roadmap-only): confirmed clean via full-file grep, only the two table rows reference either term.Found along the way: SSO/SAML and RBAC were investigated in the same pass and confirmed genuinely still unshipped (stub-only backing services,
createStubSSOService()/createStubRBACService(), no production caller ever swaps in a real implementation) — correctly left as roadmap, not touched.Net result: Pricing page now accurately reflects shipped Enterprise capabilities for audit/SIEM tooling.
Technical detail
<li>list: removed "Audit logging (MCP tools)" and "SIEM export"; left SSO/SAML and RBAC untouched (verified separately as genuinely unshipped).Pre-existing issue exception (CLAUDE.md zero-deferral exception clause)
Pushed via
--no-verifywith explicit consent — pre-push's npm audit check fails on SMI-5775 (brace-expansion High/DoS + astro Moderate/XSS + others onmain), a pre-existing, already-tracked, unrelated dependency vulnerability independently discovered by a concurrent session ~30 min before this PR. This diff touches onlypricing.astrocontent — nopackage.json/package-lock.jsonchanges. Every other pre-push check (format, tests, secrets, typecheck,astro check) passed clean before hitting the audit gate. SMI-5775's actual fix requiresnpm audit fixinside the long-livedskillsmith-dev-1container (worktree containers structurally can't run it — read-onlynode_modulesmounts by design), which was contended by other concurrent sessions at push time.Refs SMI-5735, SMI-3140, SMI-5688, SMI-5775.