test(hooks): fix stale docstring in worktree-port-collision fixture#1971
Merged
Conversation
write_fixed_override's docstring claimed its 4 port lines 'match the real generator's shape' -- no longer true since SMI-5719 deleted the orchestrator service and the real generator now only ever writes 3 ports. Investigated whether to shrink the fixture to match (the Linear issue's other proposed fix) instead: traced through _resolve_worktree_port_offset's collision-check loop and confirmed it still reserves and checks all 4 slots in a bucket regardless of what a real override populates, so shrinking would silently drop test coverage for the reserved-but-currently-unwritten 4th slot. Fixed the docstring instead, plus an inline comment at the fictional orchestrator: block so the fixture's intent is visible at the point of use, not just 14 lines above in the docstring. No functional change -- still 22/22 tests passing, no port values changed. Fixes SMI-5748 Co-Authored-By: claude-flow <ruv@ruv.net> Co-Authored-By: Claude <noreply@anthropic.com>
E2E Test ResultsE2E Test Results - July 20, 2026Summary
Test Results
Generated by skillsmith E2E test suite |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Business Summary
What shipped: A test-fixture docstring that claimed to "match the real generator's shape" was corrected — it no longer does, since an earlier cleanup deleted the service that shape referred to. Investigated the alternative fix (shrinking the fixture to match) and found it would have silently reduced test coverage, so kept the wider shape and documented why instead.
Quality bar: Plan-reviewed (no blockers) with an independent trace through the actual collision-detection code confirming the reasoning. No functional change — still 22/22 tests passing, same port values.
Net result: Fully shipped, no follow-up (this file's own CI-wiring gap is tracked separately under SMI-5771).
Technical detail
scripts/tests/worktree-port-collision.test.sh— rewrotewrite_fixed_override's docstring to explain why it intentionally still emits a 4th "orchestrator" port slot (no such service exists anymore) rather than shrinking to match the real generator's current 3-port output: the collision-check loop it tests still reserves and checks the full 4-port bucket width regardless of what a real override populates, so shrinking the fixture would drop coverage of that reserved slot. Added an inline comment at the fixture body's fictionalorchestrator:block so this is visible without reading the docstring 14 lines above.Fixes SMI-5748.