Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR aims to genericize the version variable names by replacing SSP_VERSION with VERSION across the Docker workflow.
- Updated environment variable names and comments in docker.yml
- Renamed step IDs and output references accordingly
Comments suppressed due to low confidence (1)
.github/workflows/docker.yml:34
- [nitpick] The step name still references 'SimpleSAMLphp version' even though the variable has been genericized to 'VERSION'. Consider updating the step name to reflect the generic nature of the variable.
- name: Determine SimpleSAMLphp version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.