Better runloop integration #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlafroscia
force-pushed
the
better-runloop-integration
branch
from
b0d2de7 to
b77fd50
Compare
alexlafroscia
force-pushed
the
better-runloop-integration
branch
from
b77fd50 to
20d68b8
Compare
|
@alexlafroscia : thanks for these awesome patches. |
|
You're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get
nprogressto play nicely with the run loop,nprogressshouldn't usewindow.setTimeout. However, it does not provide any way to do that...... until now! I forked
nprogressand added support for a custom scheduler function; the PR for that can be found here. I have no idea if, or when, that is going to be accepted, so for the time being I added my fork as a dependency of the project. Considering the lack of movement on the PRs that are already open on that repo, it may be a long time, but if it's ever closed then I'll update the Bower version in this addon, too.