Skip to content

feat: anchor launch decisions on the invocation context pane #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
diegopzz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: anchor launch decisions on the invocation context pane #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion scripts/open-file-viewer-tab.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,14 @@ script_dir="$(cd "$(dirname "${BASH_SOURCE[0]:-$0}")" && pwd)"
viewer_bin="$script_dir/../target/release/herdr-file-viewer"

open_tab() {
# extra args: `--workspace <id>` when the decision named an anchor — a
# context-carrying (programmatic) invocation opens the tab in THAT
# workspace, not the host's focused one. Validated by --launch-decision-tab.
exec "$herdr_bin" plugin pane open \
--plugin herdr-file-viewer \
--entrypoint file-viewer \
--placement tab \
--focus
--focus "$@"
}

decision="OPEN"
Expand Down Expand Up @@ -57,6 +60,9 @@ case "$decision" in
pid="${decision#CLOSE }"
exec "$herdr_bin" pane close "$pid"
;;
"OPEN "*)
open_tab --workspace "${decision#OPEN }"
;;
*)
open_tab
;;
Expand Down
8 changes: 7 additions & 1 deletion scripts/open-file-viewer.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,15 @@ script_dir="$(cd "$(dirname "${BASH_SOURCE[0]:-$0}")" && pwd)"
viewer_bin="$script_dir/../target/release/herdr-file-viewer"

open_pane() {
# extra args: `--target-pane <id>` when the decision named an anchor — a
# context-carrying (programmatic) invocation splits THAT pane, not the
# host's focused one. The id was validated flag-safe by --launch-decision.
exec "$herdr_bin" plugin pane open \
--plugin herdr-file-viewer \
--entrypoint file-viewer \
--placement split \
--direction right \
--focus
--focus "$@"
}

decision="OPEN"
Expand All @@ -49,6 +52,9 @@ case "$decision" in
pid="${decision#CLOSE }"
exec "$herdr_bin" pane close "$pid"
;;
"OPEN "*)
open_pane --target-pane "${decision#OPEN }"
;;
*)
open_pane
;;
Expand Down
Loading