fix: native Windows pane spawning and manifest tests - #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds native Windows plugin pane spawning support (available since herdr v0.8.0-preview) and fixes manifest tests for native Windows pane.
Changes
Native Windows Pane Spawning
command = ["herdr-file-viewer"]withplatforms = ["linux", "macos", "windows"]~/.local/bin/herdr-file-viewer.exe(symlink to binary)Windows Launcher Scripts (with version detection & fallback)
scripts/open-file-viewer-windows.ps1- split panescripts/open-file-viewer-tab-windows.ps1- new tabherdr --version, uses native if >= v0.8.0pane split+pane run+send-keysfor herdr < v0.8.0Build System
scripts/fetch-or-build.ps1andscripts/fetch-or-build.shto create PATH shim at~/.local/bin/herdr-file-viewer.exe(symlink)open-file-viewer.ps1,open-file-viewer-tab.ps1herdr-plugin.tomlwith cross-platform pane and Windows-specific actionsTests Updated
tests/launcher_ps1.rs: Updated for new script names (open-file-viewer-windows.ps1,open-file-viewer-tab-windows.ps1)tests/launcher_content.rs: Updated script names, validated call-operator spawn, UTF-8 JSON handling, config dir passingtests/manifest.rs: Updated for native Windows pane supportcargo test launcher_ps1,cargo test launcher_content,cargo test manifestBackward Compatibility
herdr --version, uses native if >= v0.8.0pane split+pane run+send-keysTesting
cargo testpass (282/283 pass, 1 pre-existing unrelated failure)