-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solana updates #15831
base: develop
Are you sure you want to change the base?
Solana updates #15831
Conversation
Quality Gate passedIssues Measures |
AER Report: CI Coreaer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , Core Tests (go_core_tests) , GolangCI Lint (deployment) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , test-scripts , Core Tests (go_core_race_tests) , lint , SonarQube Scan 1. Not enough arguments in call to deployment.NewEnvironment: [Golang Lint (deployment)]Source of Error:deployment/keystone/changeset/internal/test/utils.go:18:2: could not import github.com/smartcontractkit/chainlink/deployment/environment/memory (-: # github.com/smartcontractkit/chainlink/deployment/environment/memory
environment/memory/environment.go:155:3: not enough arguments in call to deployment.NewEnvironment
have (string, "github.com/smartcontractkit/chainlink-common/pkg/logger".Logger, *deployment.AddressBookMap, map[uint64]deployment.Chain, []string, *JobClient, func() "context".Context, deployment.OCRSecrets)
want (string, "github.com/smartcontractkit/chainlink-common/pkg/logger".Logger, deployment.AddressBook, map[uint64]deployment.Chain, map[uint64]deployment.SolChain, []string, deployment.OffchainClient, func() "context".Context, deployment.OCRSecrets)
environment/memory/environment.go:175:3: not enough arguments in call to deployment.NewEnvironment
have (string, "github.com/smartcontractkit/chainlink-common/pkg/logger".Logger, *deployment.AddressBookMap, map[uint64]deployment.Chain, []string, *JobClient, func() "context".Context, deployment.OCRSecrets)
want (string, "github.com/smartcontractkit/chainlink-common/pkg/logger".Logger, deployment.AddressBook, map[uint64]deployment.Chain, map[uint64]deployment.SolChain, []string, deployment.OffchainClient, func() "context".Context, deployment.OCRSecrets)) (typecheck)
"github.com/smartcontractkit/chainlink/deployment/environment/memory"
^ Why: The function Suggested fix: Update the calls to 2. Declared and not used: [Golang Lint (deployment)]Source of Error:deployment/common/changeset/set_config_mcms_test.go:36:2: declared and not used: config (typecheck)
config := proposalutils.SingleGroupTimelockConfig(t)
^
deployment/common/changeset/example/link_transfer_test.go:36:2: declared and not used: config (typecheck)
config := proposalutils.SingleGroupMCMS(t)
^
deployment/environment/crib/ccip_deployer.go:133:5: declared and not used: stateChain1 (typecheck)
stateChain1 := state.Chains[from]
^
deployment/keystone/changeset/accept_ownership_test.go:54:2: declared and not used: timelock (typecheck)
timelock, err := commonchangeset.MaybeLoadMCMSWithTimelockChainState(env.Chains[registrySel], addrs)
^
deployment/keystone/changeset/append_node_capabilities_test.go:91:3: declared and not used: contracts (typecheck)
contracts := te.ContractSets()[te.RegistrySelector]
^
deployment/keystone/changeset/deploy_ocr3_test.go:121:3: declared and not used: contracts (typecheck)
contracts := te.ContractSets()[te.RegistrySelector]
^
deployment/keystone/changeset/update_don_test.go:114:3: declared and not used: contracts (typecheck)
contracts := te.ContractSets()[te.RegistrySelector]
^ Why: Variables are declared but not used within the code, which is flagged by the linter as an error. Suggested fix: Remove the unused variable declarations or use them appropriately within the code. 3. Not enough arguments in call to deployment.NewEnvironment: [Core Tests (go_core_ccip_deployment_tests)]Source of Error:environment/devenv/environment.go:55:3: not enough arguments in call to deployment.NewEnvironment
have (string, "github.com/smartcontractkit/chainlink-common/pkg/logger".Logger, *"github.com/smartcontractkit/chainlink/deployment".AddressBookMap, map[uint64]"github.com/smartcontractkit/chainlink/deployment".Chain, []string, "github.com/smartcontractkit/chainlink/deployment".OffchainClient, func() "context".Context, "github.com/smartcontractkit/chainlink/deployment".OCRSecrets)
want (string, "github.com/smartcontractkit/chainlink-common/pkg/logger".Logger, "github.com/smartcontractkit/chainlink/deployment".AddressBook, map[uint64]"github.com/smartcontractkit/chainlink/deployment".Chain, map[uint64]"github.com/smartcontractkit/chainlink/deployment".SolChain, []string, "github.com/smartcontractkit/chainlink/deployment".OffchainClient, func() "context".Context, "github.com/smartcontractkit/chainlink/deployment".OCRSecrets)
environment/memory/environment.go:155:3: not enough arguments in call to deployment.NewEnvironment
have (string, "github.com/smartcontractkit/chainlink-common/pkg/logger".Logger, *deployment.AddressBookMap, map[uint64]deployment.Chain, []string, *JobClient, func() "context".Context, deployment.OCRSecrets)
want (string, "github.com/smartcontractkit/chainlink-common/pkg/logger".Logger, deployment.AddressBook, map[uint64]deployment.Chain, map[uint64]deployment.SolChain, []string, deployment.OffchainClient, func() "context".Context, deployment.OCRSecrets)
environment/memory/environment.go:175:3: not enough arguments in call to deployment.NewEnvironment
have (string, "github.com/smartcontractkit/chainlink-common/pkg/logger".Logger, *deployment.AddressBookMap, map[uint64]deployment.Chain, []string, *JobClient, func() "context".Context, deployment.OCRSecrets)
want (string, "github.com/smartcontractkit/chainlink-common/pkg/logger".Logger, deployment.AddressBook, map[uint64]deployment.Chain, map[uint64]deployment.SolChain, []string, deployment.OffchainClient, func() "context".Context, deployment.OCRSecrets) Why: Similar to the first error, the function Suggested fix: Update the calls to |
Requires
Supports