Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPCC: Ink #15828

Merged
merged 11 commits into from
Jan 7, 2025
Merged

OPCC: Ink #15828

merged 11 commits into from
Jan 7, 2025

Conversation

athegaul
Copy link
Contributor

@athegaul athegaul commented Jan 3, 2025

This PR introduces the Ink chain configuration, which is currently undergoing testing and will soon be integrated.

@athegaul athegaul requested review from a team as code owners January 3, 2025 06:02
Copy link
Contributor

github-actions bot commented Jan 3, 2025

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@athegaul athegaul requested a review from a team as a code owner January 3, 2025 14:46
@athegaul athegaul requested a review from Atrax1 January 3, 2025 14:46
Comment on lines +23 to +24
[GasEstimator.BlockHistory]
BlockHistorySize = 100
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still need this? if going with Fee History I don't think this needs to be added

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need this if it has EIP1559, atleast thats what I heard

@athegaul athegaul changed the title OPCC: Ink Sepolia OPCC: Ink Jan 6, 2025
simsonraj
simsonraj previously approved these changes Jan 6, 2025
@joaoluisam joaoluisam self-requested a review January 7, 2025 14:28
@jmank88 jmank88 enabled auto-merge January 7, 2025 15:39
@jmank88 jmank88 added this pull request to the merge queue Jan 7, 2025
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Merged via the queue into develop with commit 9594e82 Jan 7, 2025
168 of 169 checks passed
@jmank88 jmank88 deleted the OPCC/ink branch January 7, 2025 16:07
ogtownsend added a commit to smartcontractkit/ccip that referenced this pull request Jan 8, 2025
Cherry picking core PRs into ccip:
1. smartcontractkit/chainlink#15828 
2. smartcontractkit/chainlink#15858
3. smartcontractkit/chainlink#15735

---------

Co-authored-by: Jasmin Bakalovic <[email protected]>
Co-authored-by: joaoluisam <[email protected]>
Co-authored-by: Friedemann Fürst <[email protected]>
Co-authored-by: Sishir Giri <[email protected]>
Co-authored-by: Dmytro Haidashenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants