Solana plugin

[archseer]

No description provided.

[github-actions]

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

[huangzhen1997]

Thanks for making this, looks good to me. Do you want to merge this or create it as a base branch ?

[prashantkumar1982]

The previous code had comment "// TODO: Validate that that all EVM chains are using the same keybundle."

Based on that, does it make sense to validate that if a bundle exists for a family, ensure it is same

keyBundleId, exists := keyBundles[family]
if exists {
if keyBundleId != config.KeyBundleID
return deployment.ChangesetOutput{}, new Error("A family is not using the same keyBundle")
}

[archseer]

I resolved the TODO since that's the implicit behaviour we've used for keystone too. A single key is automatically generated for each family (as long as there's a relayer for that family type), so using different ones is unexpected

I'll add that check in 👍🏻

[cl-sonarqube-production]

Quality Gate passed

Issues
1 New issue
3 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube