-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solana plugin codec implementation #15816
base: develop
Are you sure you want to change the base?
Solana plugin codec implementation #15816
Conversation
AER Report: CI Coreaer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , Core Tests (go_core_tests) , GolangCI Lint (core/scripts) , Core Tests (go_core_tests_integration) , test-scripts , GolangCI Lint (.) , Core Tests (go_core_ccip_deployment_tests) , GolangCI Lint (integration-tests) , Core Tests (go_core_fuzz) , GolangCI Lint (deployment) , Core Tests (go_core_race_tests) , lint , SonarQube Scan 1. Undefined: capabilities_registry (typecheck):[Golang Lint (deployment)]Source of Error:deployment/ccip/changeset/internal/deploy_home_chain.go:79:35: undefined: capabilities_registry (typecheck)
func getNodeOperatorIDMap(capReg *capabilities_registry.CapabilitiesRegistry, maxNops uint32) (map[string]uint32, error) {
^
deployment/ccip/changeset/internal/deploy_home_chain.go:98:30: undefined: capabilities_registry (typecheck)
func LatestCCIPDON(registry *capabilities_registry.CapabilitiesRegistry) (*capabilities_registry.CapabilitiesRegistryDONInfo, error) {
^
deployment/ccip/changeset/internal/deploy_home_chain.go:116:30: undefined: capabilities_registry (typecheck)
func DonIDForChain(registry *capabilities_registry.CapabilitiesRegistry, ccipHome *ccip_home.CCIPHome, chainSelector uint64) (uint32, error) {
^ Suggested fix: Ensure that the 2. Missing method BalanceAt (typecheck):[Golang Lint (deployment)]Source of Error:deployment/multiclient.go:43:23: cannot use &MultiClient{} (value of type *MultiClient) as OnchainClient value in variable declaration: *MultiClient does not implement OnchainClient (missing method BalanceAt) (typecheck)
var _ OnchainClient = &MultiClient{}
^ Suggested fix: Implement the 3. Undefined: ethereum (typecheck):[Golang Lint (deployment)]Source of Error:deployment/helpers.go:52:10: undefined: ethereum (typecheck)
call := ethereum.CallMsg{
^ Suggested fix: Ensure that the 4. Declared and not used: onRamp100 (typecheck):[Golang Lint (deployment)]Source of Error:deployment/address_book_test.go:76:2: declared and not used: onRamp100 (typecheck)
onRamp100 := NewTypeAndVersion("OnRamp", Version1_0_0)
^
deployment/address_book_test.go:77:2: declared and not used: onRamp110 (typecheck)
onRamp110 := NewTypeAndVersion("OnRamp", Version1_1_0)
^
deployment/address_book_test.go:129:2: declared and not used: onRamp100 (typecheck)
onRamp100 := NewTypeAndVersion("OnRamp", Version1_0_0)
^
deployment/address_book_test.go:130:2: declared and not used: onRamp110 (typecheck)
onRamp110 := NewTypeAndVersion("OnRamp", Version1_1_0)
^
deployment/address_book_test.go:250:2: declared and not used: onRamp120 (typecheck)
onRamp120 := NewTypeAndVersion("OnRamp", Version1_2_0)
^ Suggested fix: Remove the unused variable declarations or use them in the code. 5. Undefined field or method Timelock (typecheck):[Golang Lint (deployment)]Source of Error:deployment/ccip/changeset/cs_ccip_home.go:470:63: state.Chains[cfg.HomeChainSelector].Timelock undefined (type CCIPChainState has no field or method Timelock) (typecheck)
cfg.HomeChainSelector: state.Chains[cfg.HomeChainSelector].Timelock.Address(),
^
deployment/ccip/changeset/cs_ccip_home.go:473:63: state.Chains[cfg.HomeChainSelector].ProposerMcm undefined (type CCIPChainState has no field or method ProposerMcm) (typecheck)
cfg.HomeChainSelector: state.Chains[cfg.HomeChainSelector].ProposerMcm,
^ Suggested fix: Ensure that the 6. Undefined: gethParams.Version (typecheck):[Run Tests]Source of Error:../gethwrappers/abigen.go:52:27: undefined: gethParams.Version
../gethwrappers/abigen.go:55:15: undefined: gethParams.Version Suggested fix: Ensure that the 7. Missing go.sum entry for module providing package github.com/ethereum/go-ethereum (imported by github.com/smartcontractkit/chainlink/deployment):[Run tests]Source of Error:helpers.go:11:2: missing go.sum entry for module providing package github.com/ethereum/go-ethereum (imported by github.com/smartcontractkit/chainlink/deployment); to add:
go get github.com/smartcontractkit/chainlink/deployment Suggested fix: Run 8. Not enough arguments in call to client.Decode (typecheck):[Golang Lint (integration-tests)]Source of Error:integration-tests/universal/log_poller/helpers.go:823:124: not enough arguments in call to client.Decode
have (unknown type)
want (*"github.com/ethereum/go-ethereum/core/types".Transaction, error) (typecheck)
_, err = client.Decode((*task.emitter).EmitLogIntsFromKey(getIntSlice(*cfg.General.EventsPerTx), client.AnySyncedKey()))
^
integration-tests/universal/log_poller/helpers.go:825:131: not enough arguments in call to client.Decode
have (unknown type)
want (*"github.com/ethereum/go-ethereum/core/types".Transaction, error) (typecheck)
_, err = client.Decode((*task.emitter).EmitLogIntsIndexedFromKey(getIntSlice(*cfg.General.EventsPerTx), client.AnySyncedKey()))
^
integration-tests/universal/log_poller/helpers.go:827:130: not enough arguments in call to client.Decode
have (unknown type)
want (*"github.com/ethereum/go-ethereum/core/types".Transaction, error) (typecheck)
_, err = client.Decode((*task.emitter).EmitLogStringsFromKey(getStringSlice(*cfg.General.EventsPerTx), client.AnySyncedKey()))
^ Suggested fix: Ensure that the correct number and types of arguments are passed to the 9. Declared and not used: ownerChainB (typecheck):[Golang Lint (integration-tests)]Source of Error:integration-tests/smoke/ccip/ccip_usdc_test.go:52:2: declared and not used: ownerChainB (typecheck)
ownerChainB := e.Chains[chainB].DeployerKey
^ Suggested fix: Remove the unused variable declaration or use it in the code. 10. Can't run linter goanalysis_metalinter (typecheck):[Golang Lint (core/scripts)]Source of Error:level=warning msg="[runner] Can't run linter goanalysis_metalinter: inspect: failed to load package keeper: could not load export data: no export data for \"github.com/smartcontractkit/chainlink/v2/core/services/keeper\""
level=error msg="Running error: can't run linter goanalysis_metalinter\ninspect: failed to load package keeper: could not load export data: no export data for \"github.com/smartcontractkit/chainlink/v2/core/services/keeper\"" Suggested fix: Ensure that the 11. Process completed with exit code 1 (git diff --stat --cached --exit-code):[Ensure clean after generate]Source of Error:deployment/mocks/offchain_client_mock.go | 1375 ------------------------------
go.md | 22 +-
2 files changed, 20 insertions(+), 1377 deletions(-) Suggested fix: Ensure that all generated files are committed to the repository before running the generate command. AER Report: Operator UI CI ran successfully ✅ |
…NONEVM-935/implement-ccip-solana-plugin-codec
…NONEVM-935/implement-ccip-solana-plugin-codec
Quality Gate passedIssues Measures |
Jira reference:
https://smartcontract-it.atlassian.net/browse/NONEVM-935