Skip to content

MCMS: Add WrongNonce error for EVM to skip #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

MCMS: Add WrongNonce error for EVM to skip #539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
efc2ad7
Add WrongNonce error for EVM to skip
simsonraj Oct 24, 2025
5623134
Merge branch 'main' into fix-skip-nonce-errors
simsonraj Dec 1, 2025
c4a6f26
updated comment
simsonraj Dec 1, 2025
49e0fac
added changeset
simsonraj Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/perky-jars-flash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink-deployments-framework": patch
---

Add WrongNonce string to skip during Nonce errors during mcms execution
9 changes: 5 additions & 4 deletions engine/cld/legacy/cli/mcmsv2/mcms_v2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ import (
gethtypes "github.com/ethereum/go-ethereum/core/types"
"github.com/ethereum/go-ethereum/crypto"
chainsel "github.com/smartcontractkit/chain-selectors"
"github.com/smartcontractkit/chainlink-testing-framework/framework/components/blockchain"
"github.com/smartcontractkit/chainlink-testing-framework/framework/rpc"
"github.com/smartcontractkit/mcms"
"github.com/smartcontractkit/mcms/sdk"
"github.com/smartcontractkit/mcms/sdk/aptos"
Expand All @@ -33,6 +31,9 @@ import (
"go.uber.org/zap"
"go.uber.org/zap/zapcore"

"github.com/smartcontractkit/chainlink-testing-framework/framework/components/blockchain"
"github.com/smartcontractkit/chainlink-testing-framework/framework/rpc"

"github.com/smartcontractkit/chainlink-deployments-framework/pkg/logger"

suibindings "github.com/smartcontractkit/chainlink-sui/bindings"
Expand Down Expand Up @@ -1294,8 +1295,8 @@ func isNonceError(rawErr error, selector uint64) (bool, error) {
switch family {
case chainsel.FamilyEVM:
decodedErr := cldf.DecodeErr(bindings.ManyChainMultiSigABI, rawErr)
// Check if the error contains PostOpCountReached
if strings.Contains(decodedErr.Error(), "PostOpCountReached") {
// Check if the error contains PostOpCountReached / WrongNonce
if strings.Contains(decodedErr.Error(), "WrongNonce") || strings.Contains(decodedErr.Error(), "PostOpCountReached") {
return true, nil
}

Expand Down