Repository navigation
fix(gcp-marketplace): make the listing deployable and document it - #52
Merged
Merged
Conversation
aelmanaa
requested review from
a team,
Angelin01 and
khalifaa55
as code owners
September 24, 2026 14:23
Contributor
|
👋 aelmanaa, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Angelin01
reviewed
Sep 24, 2026
Angelin01
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several documentation and configuration improvements for deploying Chainlink CCV Cells, with a particular focus on clarifying secrets management, service account setup, and support for different Gateway API route kinds in GCP Marketplace deployments. The changes aim to improve the clarity and flexibility of deployment instructions, especially for users leveraging Google Cloud Marketplace and various cloud secret management backends.
Key changes include:
Documentation and Deployment Guidance
create: trueorfalse, and clarified the implications for GCP Marketplace users.Secret Management and Configuration
dbUrlRemoteReffor the verifier's bootstrap secret is only needed whenkeystoreBackendis set topostgres, both in documentation and in the Helm chart templates. [1] [2] [3] [4]Gateway API Route Kind Flexibility
GRPCRouteandHTTPRoutefor the aggregator's Gateway API resource, with schema validation, documentation, and template logic to handle both kinds. This is important for compatibility with GKE's managed Gateway, which only supportsHTTPRoute. [1] [2] [3] [4]Schema and Validation Updates
signer_addressfield to allow the valueautofor automatic key generation on first deployment, with improved documentation.These changes collectively improve the deployment experience, reduce the risk of misconfiguration, and ensure compatibility with a broader range of cloud environments and Gateway controllers.