Repository navigation
fix(chart): emit keystore.kms provider so a KMS keystore starts - #50
Merged
Merged
Conversation
aelmanaa
requested review from
a team,
Angelin01 and
khalifaa55
as code owners
September 20, 2026 19:48
Contributor
|
👋 aelmanaa, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
khalifaa55
previously approved these changes
Sep 21, 2026
Angelin01
reviewed
Sep 21, 2026
Co-authored-by: Angelo Borsoi Ross <angelo.ross@nethermind.io>
Co-authored-by: Angelo Borsoi Ross <angelo.ross@nethermind.io>
khalifaa55
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves and clarifies how the verifier's signing key is managed and configured, especially when using a cloud Key Management Service (KMS) backend. The changes introduce explicit support for selecting a KMS provider (AWS or GCP), update documentation and configuration files for better guidance, and ensure the Helm chart templates and schema enforce these requirements.
Key improvements and clarifications:
KMS Provider Support & Configuration:
providerfield underverifier.secrets.bootstrap.kmsto specify the cloud KMS provider (awsorgcp) whenkeystoreBackendis set tokms, with corresponding updates invalues.yaml, the schema, and the Helm template logic. [1] [2] [3]Documentation Updates:
RUNBOOK.md) with a new section on the keystore backend, including configuration examples for both Postgres and KMS, and clear instructions for different secret management strategies.README.mdandREADME.md.gotmpl) to explain how to configure the KMS backend and reference further documentation for production deployments. [1] [2]Template Logic Improvements:
externalsecret.yamlto require and inject the KMSproviderfield, and to only include theed25519_key_idif it is provided.These changes make the configuration for cloud KMS-backed signing keys more robust, explicit, and easier to understand for both development and production deployments.