Repository navigation
Create gcp deployer - #3
Conversation
|
Thank you for adding a CODEOWNERS file - @Angelin01. |
|
👋 Angelin01, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
5d2c878 to
0adddbf
Compare
There was a problem hiding this comment.
Pull request overview
Adds the initial Google Cloud Marketplace “deployer” image inputs (schema + Helm wrapper chart + verification overlay) to support running mpdev verify and to establish a baseline for future CI/image publishing work.
Changes:
- Introduces a GCP Marketplace schema (
schema.yaml) and a wrapper Helm chart (chart/ccv-cell-mp) around the existingcharts/ccv-cell. - Adds a
deployer_helm-based Dockerfile that packages the chart + schema and includes adata-testverification bundle. - Adds
data-testoverlays (schema, values, templates) to stand up local verification dependencies (Postgres, test secrets, readiness tester).
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| marketplace/gcp/schema.yaml | Defines Marketplace v2 schema parameters for CCV cell install. |
| marketplace/gcp/Dockerfile | Builds a Marketplace deployer image containing packaged chart + schemas (prod + data-test). |
| marketplace/gcp/data-test/schema.yaml | Defines verification-time schema parameters and image parameterization for mpdev verify. |
| marketplace/gcp/data-test/chart-overlay/values.yaml | Verification overlay values (local Postgres, curl tester, bootstrap config). |
| marketplace/gcp/data-test/chart-overlay/templates/verify-tester.yaml | Helm test hook pod to wait for aggregator/verifier health endpoints. |
| marketplace/gcp/data-test/chart-overlay/templates/verify-secrets.yaml | Verification-only secrets for local bootstrap (Postgres URLs, key import). |
| marketplace/gcp/data-test/chart-overlay/templates/verify-postgres.yaml | Verification-only in-cluster Postgres StatefulSet + Service. |
| marketplace/gcp/data-test/chart-overlay/templates/_images.tpl | Helper template for composing image references from registry/repo/tag. |
| marketplace/gcp/chart/ccv-cell-mp/values.yaml | Default values for Marketplace wrapper (grpcRoute + ccv-cell value overrides). |
| marketplace/gcp/chart/ccv-cell-mp/templates/grpcroute.yaml | Wrapper-level GRPCRoute for exposing aggregator gRPC via Gateway API. |
| marketplace/gcp/chart/ccv-cell-mp/templates/application.yaml | Creates an Application CR to group deployed resources in Marketplace. |
| marketplace/gcp/chart/ccv-cell-mp/Chart.yaml | Defines the wrapper chart and its dependency on charts/ccv-cell. |
| marketplace/gcp/.gitignore | Ignores vendored chart dependency artifacts under wrapper chart. |
| marketplace/gcp/.dockerignore | Restricts Docker build context to Marketplace chart + schema + data-test assets. |
Suppressed comments (2)
marketplace/gcp/chart/ccv-cell-mp/templates/application.yaml:27
componentKinds[].groupshould be the API group only (e.g.apps), notapps/v1(which includes the version). Withapps/v1the Application controller may not match StatefulSets correctly.
- group: apps/v1
kind: StatefulSet
marketplace/gcp/chart/ccv-cell-mp/templates/application.yaml:25
Application.spec.componentKinds[].groupexpects an API group (empty for core resources), not a version string likev1. Usingv1here can prevent the Application controller from correctly associating owned components.
- group: v1
kind: ConfigMap
- group: v1
kind: Service
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This is the basic necessary to pass
mpdev verify.We test locally against postgres with a key_import for bootstrapping.
Pending:
deployerimage and side images likepostgresandcurl.For future reference, this was the build script used locally for the deployer image, which we can translate into CI later:
Commonly called like so:
./build.sh us-docker.pkg.dev/ccip-dev-ccv-starter-kit/ccv-starter-kit/ccv-cell/deployer:0.4.0