Skip to content

Create gcp deployer - #3

Merged
Angelin01 merged 7 commits into
mainfrom
bro-1273-create-gcp-deployer
Aug 27, 2026
Merged

Angelin01 merged 7 commits into
mainfrom
bro-1273-create-gcp-deployer

Conversation

@Angelin01

Copy link
Copy Markdown
Collaborator

This is the basic necessary to pass mpdev verify.

We test locally against postgres with a key_import for bootstrapping.

Pending:

  • Application CRD needs an annotation with partner ID from the real partnership
  • CI to push images to GCP, including building and deploying the deployer image and side images like postgres and curl.
  • The config section, which for now is not exposed, we'll do it in a separate PR (with an intentional widget comment left so we remember to do it)

For future reference, this was the build script used locally for the deployer image, which we can translate into CI later:

#!/usr/bin/env bash

set -euo pipefail

image="${1:?usage: build.sh <deployer-image>:<tag>}"
tag="${image##*:}"
if [[ "$tag" == "$image" ]]; then
  echo "image reference must include a tag, e.g. .../deployer:0.1.0" >&2
  exit 1
fi

here="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"

helm dependency update "$here/chart/ccv-cell-mp"
docker build --build-arg TAG="$tag" --tag "$image" "$here"

echo "Built $image"
docker push "$image"

Commonly called like so: ./build.sh us-docker.pkg.dev/ccip-dev-ccv-starter-kit/ccv-starter-kit/ccv-cell/deployer:0.4.0

@Angelin01 Angelin01 self-assigned this Aug 26, 2026
@Angelin01
Angelin01 requested a review from a team as a code owner August 26, 2026 18:58
@github-actions

github-actions Bot commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

Thank you for adding a CODEOWNERS file - @Angelin01.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Angelin01, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@Angelin01
Angelin01 force-pushed the bro-1273-create-gcp-deployer branch from 5d2c878 to 0adddbf Compare August 26, 2026 19:01
@khalifaa55
khalifaa55 requested a lite review from Copilot August 26, 2026 19:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the initial Google Cloud Marketplace “deployer” image inputs (schema + Helm wrapper chart + verification overlay) to support running mpdev verify and to establish a baseline for future CI/image publishing work.

Changes:

  • Introduces a GCP Marketplace schema (schema.yaml) and a wrapper Helm chart (chart/ccv-cell-mp) around the existing charts/ccv-cell.
  • Adds a deployer_helm-based Dockerfile that packages the chart + schema and includes a data-test verification bundle.
  • Adds data-test overlays (schema, values, templates) to stand up local verification dependencies (Postgres, test secrets, readiness tester).

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
marketplace/gcp/schema.yaml Defines Marketplace v2 schema parameters for CCV cell install.
marketplace/gcp/Dockerfile Builds a Marketplace deployer image containing packaged chart + schemas (prod + data-test).
marketplace/gcp/data-test/schema.yaml Defines verification-time schema parameters and image parameterization for mpdev verify.
marketplace/gcp/data-test/chart-overlay/values.yaml Verification overlay values (local Postgres, curl tester, bootstrap config).
marketplace/gcp/data-test/chart-overlay/templates/verify-tester.yaml Helm test hook pod to wait for aggregator/verifier health endpoints.
marketplace/gcp/data-test/chart-overlay/templates/verify-secrets.yaml Verification-only secrets for local bootstrap (Postgres URLs, key import).
marketplace/gcp/data-test/chart-overlay/templates/verify-postgres.yaml Verification-only in-cluster Postgres StatefulSet + Service.
marketplace/gcp/data-test/chart-overlay/templates/_images.tpl Helper template for composing image references from registry/repo/tag.
marketplace/gcp/chart/ccv-cell-mp/values.yaml Default values for Marketplace wrapper (grpcRoute + ccv-cell value overrides).
marketplace/gcp/chart/ccv-cell-mp/templates/grpcroute.yaml Wrapper-level GRPCRoute for exposing aggregator gRPC via Gateway API.
marketplace/gcp/chart/ccv-cell-mp/templates/application.yaml Creates an Application CR to group deployed resources in Marketplace.
marketplace/gcp/chart/ccv-cell-mp/Chart.yaml Defines the wrapper chart and its dependency on charts/ccv-cell.
marketplace/gcp/.gitignore Ignores vendored chart dependency artifacts under wrapper chart.
marketplace/gcp/.dockerignore Restricts Docker build context to Marketplace chart + schema + data-test assets.
Suppressed comments (2)

marketplace/gcp/chart/ccv-cell-mp/templates/application.yaml:27

  • componentKinds[].group should be the API group only (e.g. apps), not apps/v1 (which includes the version). With apps/v1 the Application controller may not match StatefulSets correctly.
    - group: apps/v1
      kind: StatefulSet

marketplace/gcp/chart/ccv-cell-mp/templates/application.yaml:25

  • Application.spec.componentKinds[].group expects an API group (empty for core resources), not a version string like v1. Using v1 here can prevent the Application controller from correctly associating owned components.
    - group: v1
      kind: ConfigMap
    - group: v1
      kind: Service

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread marketplace/gcp/data-test/schema.yaml
Comment thread marketplace/gcp/.dockerignore
Comment thread marketplace/gcp/chart/ccv-cell-mp/values.yaml
Comment thread marketplace/gcp/schema.yaml
Comment thread marketplace/gcp/chart/ccv-cell-mp/templates/application.yaml Outdated
@Angelin01
Angelin01 merged commit 60d95aa into main Aug 27, 2026
6 checks passed
@aelmanaa
aelmanaa deleted the bro-1273-create-gcp-deployer branch August 27, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants