Repository navigation
Swap image bump CI to dispatch strategy - #24
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The workflow can currently fail or behave unsafely when VERSION is missing/invalid (shell interpolation + “nothing to commit” path), and should validate inputs and handle no-op bumps cleanly.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR switches the image bump automation for the ccv-cell Helm chart from a scheduled “poll for latest tag” workflow to an explicit dispatch-driven workflow, where a caller supplies the target image tag/version.
Changes:
- Replace the hourly cron trigger with
repository_dispatch(image-bump) and add aworkflow_dispatchinput (version). - Simplify the workflow to directly set aggregator/verifier image tags to the provided version and open a PR.
File summaries
| File | Description |
|---|---|
.github/workflows/helm-ccv-cell-image-bump.yml |
Move to dispatch-based bumping and simplify PR creation logic by taking an explicit VERSION input/payload. |
Review details
Suppressed comments (1)
.github/workflows/helm-ccv-cell-image-bump.yml:56
- If the requested
${VERSION}is already present invalues.yaml,git commitwill fail with "nothing to commit" (because this workflow no longer gates onneeds_bump), causing the whole run to fail. Add a guard that exits successfully when no diff is produced after thesedupdates.
git add "$VALUES"
git commit -m "bump ccv images to ${VERSION}"
git push origin "$branch"
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
a9a5e8f to
0130bad
Compare
0130bad to
00679bf
Compare
|
Why are we setting the same tag for the aggregator and verifier? |
Unfortunately, just matching the behavior from upstream at the moment. GCP Marketplace kind-of requires all tags to be the same, and upstream is going to release like that for now. So I matched it here for simplicity. See this step: https://github.com/smartcontractkit/chainlink-ccv/blob/main/.github/workflows/release-publish.yaml#L64-L97 All use the same |
Swaps to a dispatch strategy for image bumps, much simpler.
Validated in #25