feat(config): tsx, bundler resolution, verbatimModuleSyntax, noUncheckedIndexedAccess

.gitignore

@@ -1,8 +1,8 @@
 # See http://help.github.com/ignore-files/ for more about ignoring files.
 
 # compiled output
-tmp
-/out-tsc
+# root dist/ is nx libs build output (actions/apps commit their own dist/)
+/dist/
 
 # dependencies
 node_modules
@@ -59,3 +59,6 @@ bin/
 /.pnpm-store/
 
 .nx/migrate-runs
+
+# lefthook local overrides
+lefthook-local.yml

actions/advanced-triggers/src/event.ts

@@ -1,5 +1,5 @@
 import * as github from "@actions/github";
-import { PushEvent, MergeGroupEvent } from "@octokit/webhooks-types";
+import type { PushEvent, MergeGroupEvent } from "@octokit/webhooks-types";
 
 export type FileChangeEventData =
   PullRequestEventData | PushEventData | MergeGroupEventData;

actions/advanced-triggers/src/github.ts

@@ -1,6 +1,6 @@
 import * as core from "@actions/core";
-import * as github from "@actions/github";
-import { GetResponseTypeFromEndpointMethod } from "@octokit/types";
+import type * as github from "@actions/github";
+import type { GetResponseTypeFromEndpointMethod } from "@octokit/types";
 
 export type OctokitType = ReturnType<typeof github.getOctokit>;
 type ListFilesResponse = GetResponseTypeFromEndpointMethod<

actions/advanced-triggers/src/run.ts

@@ -3,7 +3,8 @@ import * as github from "@actions/github";
 
 import { getInvokeContext, getInputs } from "./run-inputs";
 import { parseFileSets, parseTriggers } from "./schema";
-import { applyTrigger, TriggerResult } from "./filters";
+import type { TriggerResult } from "./filters";
+import { applyTrigger } from "./filters";
 import { getChangedFilesGit } from "./git";
 import { getChangedFilesForMergeGroup, getChangedFilesForPR } from "./github";
 import type { OctokitType } from "./github";

actions/advanced-triggers/tsconfig.json

@@ -6,7 +6,6 @@
     "noEmit": true,
     "isolatedModules": true,
     "strict": true,
-    "esModuleInterop": true,
-    "ignoreDeprecations": "6.0"
+    "esModuleInterop": true
   }
 }

actions/apidiff-go/src/__tests__/go/compatible-changes/api.go

@@ -7,7 +7,7 @@ func PublicFunc(input string) string {
 }
 
 // NewPublicFunc is a new function added in this version (compatible)
-func NewPublicFunc(input string, prefix string) string {
+func NewPublicFunc(input, prefix string) string {
 	return prefix + ": " + input
 }
 

actions/apidiff-go/src/__tests__/go/incompatible-changes/api.go

@@ -15,7 +15,7 @@ type PublicStruct struct {
 }
 
 // NewPublicStruct creates a new PublicStruct with changed signature (BREAKING)
-func NewPublicStruct(name string, newValue string) *PublicStruct {
+func NewPublicStruct(name, newValue string) *PublicStruct {
 	return &PublicStruct{
 		Name:     name,
 		NewValue: newValue,

actions/apidiff-go/src/__tests__/go/multi-module-changed/submodule1/util.go

@@ -2,7 +2,7 @@
 package submodule1
 
 // UtilFunc is a utility function in submodule1 - signature changed!
-func UtilFunc(input string, prefix string) string {
+func UtilFunc(input, prefix string) string {
 	return prefix + ": " + input
 }
 

actions/apidiff-go/src/event.ts

@@ -1,5 +1,5 @@
 import * as github from "@actions/github";
-import { PushEvent, PullRequestEvent } from "@octokit/webhooks-types";
+import type { PushEvent, PullRequestEvent } from "@octokit/webhooks-types";
 
 export type EventData =
   PullRequestEventData | PushEventData | WorkflowDispatchEventData;

actions/apidiff-go/src/github.ts

@@ -1,5 +1,5 @@
 import * as core from "@actions/core";
-import * as github from "@actions/github";
+import type * as github from "@actions/github";
 
 export type OctokitType = ReturnType<typeof github.getOctokit>;
 

actions/apidiff-go/src/render-diff.ts

@@ -2,7 +2,8 @@
  * This logic is best maintained by an LLM. It is a bunch
  * of tedious string manipulation and formatting.
  */
-import { diffArrays, Change } from "diff";
+import type { Change } from "diff";
+import { diffArrays } from "diff";
 
 function escapeHtml(s: string) {
   return s.replace(/&/g, "&amp;").replace(/</g, "&lt;").replace(/>/g, "&gt;");

actions/apidiff-go/src/string-processor.ts

@@ -13,7 +13,7 @@ function parseElement(element: string): {
   packagePath: string;
   elementName: string;
 } {
-  let path = element.startsWith("./") ? element.slice(2) : element;
+  const path = element.startsWith("./") ? element.slice(2) : element;
   const i = path.lastIndexOf(".");
   if (i === -1) return { packagePath: "", elementName: path };
   return { packagePath: path.slice(0, i), elementName: path.slice(i + 1) };

actions/apidiff-go/src/util.ts

@@ -1,5 +1,4 @@
 import * as core from "@actions/core";
-import * as semver from "semver";
 import { basename, join } from "path";
 import { readFileSync, existsSync, copyFileSync } from "fs";
 

actions/apidiff-go/tsconfig.json

@@ -1,11 +1,11 @@
 {
   "compilerOptions": {
     "target": "esnext",
-    "module": "commonjs",
+    "module": "esnext",
     "noEmit": true,
     "isolatedModules": true,
     "strict": true,
     "esModuleInterop": true,
-    "ignoreDeprecations": "6.0"
+    "moduleResolution": "bundler"
   }
 }

actions/changed-modules-go/src/event.ts

@@ -1,5 +1,5 @@
 import * as github from "@actions/github";
-import {
+import type {
   PushEvent,
   PullRequestEvent,
   MergeGroupEvent,

actions/changed-modules-go/src/github.ts

@@ -1,6 +1,6 @@
 import * as core from "@actions/core";
-import * as github from "@actions/github";
-import { GetResponseTypeFromEndpointMethod } from "@octokit/types";
+import type * as github from "@actions/github";
+import type { GetResponseTypeFromEndpointMethod } from "@octokit/types";
 
 export type OctokitType = ReturnType<typeof github.getOctokit>;
 type ListFilesResponse = GetResponseTypeFromEndpointMethod<

actions/changed-modules-go/src/run.ts

@@ -1,14 +1,14 @@
 import * as core from "@actions/core";
 import * as github from "@actions/github";
 
-import { getInvokeContext, getInputs, RunInputs } from "./run-inputs";
+import { getInvokeContext, getInputs } from "./run-inputs";
 import { getAllGoModuleRoots, matchModules, filterPaths } from "./path-ops";
 import { getChangedFilesGit } from "./git";
 
 import { getChangedFilesForPR } from "./github";
 
 import type { OctokitType } from "./github";
-import type { InvokeContext } from "./run-inputs";
+import type { InvokeContext, RunInputs } from "./run-inputs";
 
 interface Outputs {
   modifiedModules: string[];

actions/changed-modules-go/tsconfig.json

@@ -1,11 +1,11 @@
 {
   "compilerOptions": {
     "target": "esnext",
-    "module": "commonjs",
+    "module": "esnext",
     "noEmit": true,
     "isolatedModules": true,
     "strict": true,
     "esModuleInterop": true,
-    "ignoreDeprecations": "6.0"
+    "moduleResolution": "bundler"
   }
 }

actions/changed-roots/src/event.ts

@@ -1,5 +1,5 @@
 import * as github from "@actions/github";
-import {
+import type {
   PushEvent,
   PullRequestEvent,
   MergeGroupEvent,

actions/changed-roots/src/github.ts

@@ -1,6 +1,6 @@
 import * as core from "@actions/core";
-import * as github from "@actions/github";
-import { GetResponseTypeFromEndpointMethod } from "@octokit/types";
+import type * as github from "@actions/github";
+import type { GetResponseTypeFromEndpointMethod } from "@octokit/types";
 
 export type OctokitType = ReturnType<typeof github.getOctokit>;
 type ListFilesResponse = GetResponseTypeFromEndpointMethod<

actions/changed-roots/src/run.ts

@@ -1,14 +1,14 @@
 import * as core from "@actions/core";
 import * as github from "@actions/github";
 
-import { getInvokeContext, getInputs, RunInputs } from "./run-inputs";
+import { getInvokeContext, getInputs } from "./run-inputs";
 import { getAllRoots, matchModules, filterPaths } from "./path-ops";
 import { getChangedFilesGit } from "./git";
 
 import { getChangedFilesForPR } from "./github";
 
 import type { OctokitType } from "./github";
-import type { InvokeContext } from "./run-inputs";
+import type { InvokeContext, RunInputs } from "./run-inputs";
 
 interface Outputs {
   changedRoots: string[];

actions/changed-roots/tsconfig.json

@@ -1,11 +1,11 @@
 {
   "compilerOptions": {
     "target": "esnext",
-    "module": "commonjs",
+    "module": "esnext",
     "noEmit": true,
     "isolatedModules": true,
     "strict": true,
     "esModuleInterop": true,
-    "ignoreDeprecations": "6.0"
+    "moduleResolution": "bundler"
   }
 }

actions/ci-beholder-schema-validate/src/cmd/root.go

@@ -6,11 +6,10 @@ import (
 	"github.com/spf13/cobra"
 )
 
-
 var rootCmd = &cobra.Command{
 	Use:   "ci-beholder-schema-validate",
 	Short: "Schema validation",
-	Long: `Schema validation`,
+	Long:  `Schema validation`,
 }
 
 func Execute() {
@@ -23,9 +22,7 @@ func Execute() {
 var beholderFilePath string
 
 func init() {
-
 	// add persistent flag for beholder file path
 	rootCmd.PersistentFlags().StringVarP(&beholderFilePath, "beholder-file", "f", "", "beholder file path")
 	_ = rootCmd.MarkPersistentFlagRequired("beholder-file")
-
 }

actions/ci-beholder-schema-validate/src/cmd/validate.go

@@ -11,22 +11,19 @@ import (
 var validateCmd = &cobra.Command{
 	Use:   "validate",
 	Short: "Validate schemas",
-	Long: `Validate schemas`,
-	Run: runValidateCmd,
+	Long:  `Validate schemas`,
+	Run:   runValidateCmd,
 }
 
 func init() {
 	rootCmd.AddCommand(validateCmd)
 }
 
 func runValidateCmd(cmd *cobra.Command, args []string) {
-
 	beholderFileContents, err := os.ReadFile(beholderFilePath)
 	if err != nil {
 		log.Panic(err)
 	}
 
 	fmt.Printf("beholderFileContents: %s", beholderFileContents)
-
 }
-

actions/ci-beholder-schema-validate/src/main.go

@@ -4,7 +4,6 @@ import (
 	"schema-validate/cmd"
 )
 
-
-func main()  {
+func main() {
 	cmd.Execute()
-}
+}

actions/ci-grafana-alert-test/src/comment.ts

@@ -1,5 +1,5 @@
 import * as core from "@actions/core";
-import * as github from "@actions/github";
+import type * as github from "@actions/github";
 
 export const SUMMARY_COMMENT_MARKER = "<!-- ci-grafana-alert-test:summary -->";
 

actions/ci-grafana-alert-test/tsconfig.json

@@ -1,11 +1,11 @@
 {
   "compilerOptions": {
     "target": "esnext",
-    "module": "commonjs",
+    "module": "esnext",
     "noEmit": true,
     "isolatedModules": true,
     "strict": true,
     "esModuleInterop": true,
-    "ignoreDeprecations": "6.0"
+    "moduleResolution": "bundler"
   }
 }

actions/cicd-changesets-check/src/github.ts

@@ -1,4 +1,4 @@
-import * as github from "@actions/github";
+import type * as github from "@actions/github";
 
 type Octokit = ReturnType<typeof github.getOctokit>;
 

actions/cicd-changesets-check/tsconfig.json

@@ -1,11 +1,11 @@
 {
   "compilerOptions": {
     "target": "esnext",
-    "module": "commonjs",
+    "module": "esnext",
     "noEmit": true,
     "isolatedModules": true,
     "strict": true,
     "esModuleInterop": true,
-    "ignoreDeprecations": "6.0"
+    "moduleResolution": "bundler"
   }
 }

actions/codeowners-review-analysis/src/github-gql.ts

@@ -1,7 +1,7 @@
 import * as core from "@actions/core";
-import { Octokit } from "@octokit/core";
+import type { Octokit } from "@octokit/core";
 
-import {
+import type {
   Repository,
   RateLimit,
   PullRequestReviewState,

actions/codeowners-review-analysis/src/github.ts

@@ -1,6 +1,6 @@
 import * as core from "@actions/core";
 import * as github from "@actions/github";
-import { GetResponseTypeFromEndpointMethod } from "@octokit/types";
+import type { GetResponseTypeFromEndpointMethod } from "@octokit/types";
 
 const MARKDOWN_FINGERPRINT = "<!-- chainlink-codeowners-review-analysis -->";