Use container secrets securely #2271
Open
+106
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs triage
* increases the default password length from 40 to 256 characters * adds a new ENV variable DOCKER_STEPCA_PASSWORD_FILE so the password file location can be changed * adds set_password_files() to entrypoint.sh so /home/step/secrets/password becomes a symlink in containers pointing to DOCKER_STEPCA_INIT_PASSWORD_FILE & also DOCKER_STEPCA_PASSWORD_FILE so file permissions are retained * adds podman example quadlet / run command with a 378,000 character secret * small update to README.md for new podman examples / docker examples Fixes smallstep#2270
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
40to256charactersENVvariableDOCKER_STEPCA_PASSWORD_FILEso the password file location can be changed / set on everyrunset_password_files()toentrypoint.shso/home/step/secrets/passwordbecomes asymlinkin containers pointing toDOCKER_STEPCA_INIT_PASSWORD_FILE(for backwards compatibility) & alsoDOCKER_STEPCA_PASSWORD_FILEso secret file permissions are retained378,000character secretREADME.mdfor newpodmanexamples /dockerexamplesFixes #2270
Name of feature: More secure container secrets / add podman examples
Pain or issue this feature alleviates: improves container secret file permissions
Why is this important to the project (if not answered above): you can never have too much security ;o)
Is there documentation on how to use this feature? If so, where? podman examples included - I've been using these for a few weeks now
In what environments or workflows is this feature supported? containers
In what environments or workflows is this feature explicitly NOT supported (if any)? standalone binaries
Supporting links/other PRs/issues: #2270
💔Thank you!