Mirror of aws amazon-freertos#340 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirror of aws amazon-freertos#340
Fix: PIC24_dsPIC/port.c used deprecated definition
Description
In lib/FreeRTOS/portable/MPLAB/PIC24_dsPIC/port.c deprecated definition
MPLAB_DSPIC_PORTwas used to determine if extra dsPIC specific registers values should be present inxInitialStackarray butportRESTORE_CONTEXT()macro used another condition to determine what registers should be poped from stack which caused wrong number of register actually poped from stack. At this point, afterreturning from function which called
portRESTORE_CONTEXT()wrong program counter was restored and program behavior become unpredictable.MPLAB_DSPIC_PORTwas changed to condition used for deciding whatportRESTORE_CONTEXT()macro definition should be used. Also comment line after corresponding#endifs was updatedChecklist: