Fix compilation on Apple silicon#512
Merged
fgsfdsfgs merged 2 commits intosm64pc:nightlyfrom Dec 19, 2022
Merged
Conversation
Collaborator
|
Interesting. I can't test whether this breaks builds on other Macs since I don't have any, but it doesn't look like it should, so merging. Thanks. Pinging #452 in case anyone's watching that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds are currently failing on M1 Mac due to Homebrew using a different path on M1 Macs (see Render96#47 for further details).
All credits for the fix goes to @halpz (original PR: Render96#48).
Additionally, while the Wiki often encourages parallel builds (e.g., with
make -j4),tools/Makefileis not currently safe for parallel builds as it doesn't currently account for dependencies between programs.E.g.:
More often than not, trying to compile tools with
gmake OSX_BUILD=1 -j4will fail due totabledesignfinishing to compile beforeaudiofileand then failing to link.While this would ideally be solved by introducing separate rules per program accounting for dependencies, for now I'm forcing
j1for tools.