Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtime panic with colpan or rowspan set to zero #7379

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

ogoffart
Copy link
Member

@ogoffart ogoffart commented Jan 15, 2025

Fix panic:

panicked at internal/core/layout.rs:459:33:
index out of bounds: the len is 2 but the index is 2

@ogoffart ogoffart requested a review from tronical January 15, 2025 19:26
Fix panic:
```
panicked at internal/core/layout.rs:459:33:
index out of bounds: the len is 2 but the index is 2
```
@ogoffart
Copy link
Member Author

Change the method completely and fixed the runtime panic instead

tests/cases/layout/grid_span.slint Outdated Show resolved Hide resolved
@ogoffart ogoffart merged commit a6d4346 into master Jan 16, 2025
1 of 35 checks passed
@ogoffart ogoffart deleted the olivier/fix-panic branch January 16, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants