docs(decisions): record the Deus V2 LangChain runtime ADR (LIA-388)#1022
Open
sliamh11 wants to merge 3 commits into
Open
docs(decisions): record the Deus V2 LangChain runtime ADR (LIA-388)#1022sliamh11 wants to merge 3 commits into
sliamh11 wants to merge 3 commits into
Conversation
Records the two-tier deus-native/LangChain JS harness decision and the dedicated-worktree, per-slice-PR repo strategy as a durable ADR, closing the gap where the decision only existed in vault research/session logs. Adds forward-pointer banners to the four prior ADRs it supersedes or corrects (hook-dispatch-system.md, hook-dispatch-facade-correction.md, ADR-001-hook-dispatch-service.md, backend-neutral-agent-runtime.md) with a per-layer disposition table rather than a blanket "implemented" claim, since the original design's host-enforced session-lifecycle layer is a separate, still-open question from the container-cooperative tool-call veto layer this migration ships first. Went through 4 rounds of plan review (native plan-reviewer + a required GPT-5.6-Sol co-review) before implementation — GPT caught a real execution-topology ambiguity, a premature architecture-supersession claim, and a still-coupled-today CLI/backend selection claim that the first two drafts missed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Condenses the forward-pointer banner added in badafb4 from 7 lines to 1 so `**Scope:**` stays inside drift_check.py's 20-line ADR header parse window (parse_adr only scans text.splitlines()[:20]) — the original banner length pushed Scope to line 21, tripping the pre-push adr-freshness gate as a false "missing Scope field" warning. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deus-native/LangChain JS harness decision as a durable ADR (docs/decisions/deus-v2-langchain-runtime.md) — closes the gap where the decision only lived in vault research/session logs.hook-dispatch-system.md,hook-dispatch-facade-correction.md,ADR-001-hook-dispatch-service.md,backend-neutral-agent-runtime.md), each scoped precisely — e.g. a per-layer disposition table for the hook-dispatch design rather than a blanket "implemented" claim, since the host-enforced session-lifecycle layer is a separate, still-open question (owned by milestone B3) from the container-cooperative tool-call veto layer this migration ships first.M0.1 of the Deus V2 migration roadmap (LIA-388..436, 9 milestones / 49 issues). Docs-only, no runtime behavior change —
DEUS_AGENT_BACKEND=deus-nativedoes not exist in code yet.Review process
Went through 4 rounds of plan review (native plan-reviewer + a required GPT-5.6-Sol co-review) before implementation. GPT caught 6 substantive gaps across two rounds: an execution-topology ambiguity with real trust-boundary implications for
wrapToolCall, a premature architecture-supersession claim, an overclaimed "implements the HookPipeline reference design," overclaimed LangChain lifecycle-hook equivalence, a still-coupled-today CLI/backend-selection claim, and a one-directional correction chain. All six resolved with verified precision, not verbal patching. Code-reviewer (native + GPT + GLM) and verification-gate both SHIP.Test plan
git diff --checkcleanpython3 scripts/drift_check.py --indexes— indexes in syncdrift-checkfull suite — ALL CHECKS PASSED🤖 Generated with Claude Code