Skip to content

Support psr/log v2 and v3 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tsoslow wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Support psr/log v2 and v3 #18

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
63c5f0e
Support psr/log v3
tsoslow Apr 27, 2026
e656396
Support psr/log v2
tsoslow Apr 27, 2026
a283e75
Handle level and message sent as object to log()
tsoslow Apr 27, 2026
8eaabf1
Throw exception for non-stringable message
tsoslow Apr 27, 2026
577c2ed
Add unit tests for psr/log v3
tsoslow Apr 28, 2026
36595aa
Clearer error message
tsoslow Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"psr/http-message": "^1.0",
"psr/http-server-handler": "^1.0",
"psr/http-server-middleware": "^1.0",
"psr/log": "^1.1"
"psr/log": "^1.1 || ^3.0"
Comment thread
tsoslow marked this conversation as resolved.
Outdated
},
"autoload": {
"psr-4": {
Expand Down
2 changes: 1 addition & 1 deletion src/StderrLogger.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public function __construct(string $minLevel = LogLevel::WARNING, $stream = 'php
}
}

public function log($level, $message, array $context = [])
public function log($level, $message, array $context = []): void
{
if (!isset(self::LOG_LEVEL_MAP[$level])) {
throw new InvalidArgumentException("Invalid log level: {$level}");
Comment thread
tsoslow marked this conversation as resolved.
Expand Down
2 changes: 1 addition & 1 deletion tests/Integration/IntegTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ protected function createHttpServer(ServerRequestInterface $request): HttpServer

protected function failOnLoggedErrors(): void
{
$this->logger->method('error')->willReturnCallback(function (string $message, array $context) {
$this->logger->method('error')->willReturnCallback(function ($message, array $context) {
Comment thread
tsoslow marked this conversation as resolved.
Outdated
$message = "Logged an error: {$message}\nContext:\n";
foreach ($context as $key => $value) {
$message .= "- {$key}: {$value}\n";
Expand Down
Loading