mixin: a comment for the future me

skypjack · Jan 21, 2025 · 50d23e2 · 50d23e2
1 parent b0a102b
commit 50d23e2
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/TODO b/TODO
@@ -38,4 +38,3 @@ TODO:
 * sparse_set shrink_to_fit argument for sparse array shrink policy (none, empty, deep, whatever)
 * any cdynamic to support const ownership construction
 * return meta context from meta objects
-* review sigh_mixin::insert, maybe bugged (ie with pointer stability enabled)
diff --git a/src/entt/entity/mixin.hpp b/src/entt/entity/mixin.hpp
@@ -374,6 +374,7 @@ class basic_sigh_mixin final: public Type {
         underlying_type::insert(first, last, std::forward<Args>(args)...);
 
         if(auto &reg = owner_or_assert(); !construction.empty()) {
+            // fine as long as insert passes force_back true to try_emplace
             for(const auto to = underlying_type::size(); from != to; ++from) {
                 construction.publish(reg, underlying_type::operator[](from));
             }