Open
Conversation
added basic toasts/notifications to settings.jsp to acknowledge uploaded data is processing
skynetcap
reviewed
Sep 6, 2023
| // Manually submit the form after a short delay to allow the toast to show | ||
| setTimeout(() => { | ||
| form.submit(); | ||
| }, 2000); // 2 seconds |
Owner
There was a problem hiding this comment.
I'd lower this to maybe 500, or remove entirely.
| <script> | ||
| document.addEventListener("DOMContentLoaded", function() { | ||
| const rpcForm = document.querySelector("form[action='/settings']"); | ||
| const privateKeyForm = document.querySelector("form[action='/privateKeyPost']"); |
Owner
There was a problem hiding this comment.
Could do the same with the privateKeyUpload (upload file) selector.
Owner
|
Left minor comments. |
Author
|
Will address minor comments and make the appropriate fixes. |
Repository owner
deleted a comment from
Nitesh639
Feb 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to introduce basic toasts/notifications to the Arcana settings page
When a user uploads an RPC URL or a private key correctly, a toast will appear to acknowledge the information is processing.
Additional goals: