Skip to content

core: as workaround use INVALID_STRING_PLACEHOLDER when string offset is is negative #2739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skylot merged 1 commit into from
Jan 7, 2026
+7 −1
Merged

core: as workaround use INVALID_STRING_PLACEHOLDER when string offset is is negative #2739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion jadx-core/src/main/java/jadx/core/xmlgen/BinaryXMLStrings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,13 @@ public String get(int id) {
return INVALID_STRING_PLACEHOLDER;
}

long offset = stringsStart + buffer.getInt(id * 4);
int off = buffer.getInt(id * 4);
if (off < 0) {
// read unsigned offset value is larger than Integer.MAX_VALUE
// In reality this should only happen in obfuscated APKs with invalid offsets
return INVALID_STRING_PLACEHOLDER;
}
long offset = stringsStart + off;
String extracted;
if (isUtf8) {
extracted = extractString8(this.buffer.array(), (int) offset);
Expand Down
Loading