Skip to content

Add _light postfix to color resources for light theme #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add _light postfix to color resources for light theme #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...src/main/kotlin/com/skydoves/pokedex/compose/core/designsystem/theme/PokedexBackground.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public data class PokedexBackground(
)
} else {
PokedexBackground(
color = colorResource(id = R.color.background),
color = colorResource(id = R.color.background_light),
tonalElevation = 0.dp,
)
}
Expand Down
24 changes: 12 additions & 12 deletions ...tem/src/main/kotlin/com/skydoves/pokedex/compose/core/designsystem/theme/PokedexColors.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ public data class PokedexColors(
background = colorResource(id = R.color.background_dark),
backgroundLight = colorResource(id = R.color.background800_dark),
backgroundDark = colorResource(id = R.color.background900_dark),
absoluteWhite = colorResource(id = R.color.white),
absoluteBlack = colorResource(id = R.color.black),
absoluteWhite = colorResource(id = R.color.white_light),
absoluteBlack = colorResource(id = R.color.black_light),
white = colorResource(id = R.color.white_dark),
white12 = colorResource(id = R.color.white_12_dark),
white56 = colorResource(id = R.color.white_56_dark),
Expand Down Expand Up @@ -108,16 +108,16 @@ public data class PokedexColors(
@Composable
public fun defaultLightColors(): PokedexColors = PokedexColors(
primary = colorResource(id = R.color.colorPrimary),
background = colorResource(id = R.color.background),
backgroundLight = colorResource(id = R.color.background800),
backgroundDark = colorResource(id = R.color.background900),
absoluteWhite = colorResource(id = R.color.white),
absoluteBlack = colorResource(id = R.color.black),
white = colorResource(id = R.color.white),
white12 = colorResource(id = R.color.white_12),
white56 = colorResource(id = R.color.white_56),
white70 = colorResource(id = R.color.white_70),
black = colorResource(id = R.color.black),
background = colorResource(id = R.color.background_light),
backgroundLight = colorResource(id = R.color.background800_light),
backgroundDark = colorResource(id = R.color.background900_light),
absoluteWhite = colorResource(id = R.color.white_light),
absoluteBlack = colorResource(id = R.color.black_light),
white = colorResource(id = R.color.white_light),
white12 = colorResource(id = R.color.white_12_light),
white56 = colorResource(id = R.color.white_56_light),
white70 = colorResource(id = R.color.white_70_light),
black = colorResource(id = R.color.black_light),
gray21 = colorResource(id = R.color.gray_21),
bug = colorResource(id = R.color.bug),
dark = colorResource(id = R.color.dark),
Expand Down
18 changes: 9 additions & 9 deletions core/designsystem/src/main/res/values/colors.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,13 @@
<color name="black_dark">#ffffff</color>

<!-- light colors-->
<color name="background">#F4EBF4</color>
<color name="background800">#D0C7C7</color>
<color name="background900">#FFFFFF</color>
<color name="white_12">#1F000000</color>
<color name="white_56">#8F000000</color>
<color name="white_70">#B3000000</color>
<color name="white_93">#ED000000</color>
<color name="white">#ffffff</color>
<color name="black">#000000</color>
<color name="background_light">#F4EBF4</color>
<color name="background800_light">#D0C7C7</color>
<color name="background900_light">#FFFFFF</color>
<color name="white_12_light">#1F000000</color>
<color name="white_56_light">#8F000000</color>
<color name="white_70_light">#B3000000</color>
<color name="white_93_light">#ED000000</color>
<color name="white_light">#ffffff</color>
<color name="black_light">#000000</color>
</resources>
Loading