Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avoid expired thumbnails #1

Merged
merged 2 commits into from
Feb 18, 2022
Merged

feat: avoid expired thumbnails #1

merged 2 commits into from
Feb 18, 2022

Conversation

jemayn
Copy link

@jemayn jemayn commented Feb 10, 2022

In combination with limbo-works/Limbo.Integrations.Skyfish#3 this PR will generate new img thumbnail urls each time they are called.

@abjerner
Copy link
Member

@jemayn I can confirm that this builds with the newest version of the integration package 👍

Btw - ideally you shouldn't bump the value of the <Version> for feature changes. Eg. if we're later to revert or cherry pick commits, I prefer that the version is bumped in a separate commit (typically the one where we'd also build the NuGet package).

@abjerner abjerner merged commit cb226f0 into main Feb 18, 2022
@abjerner abjerner deleted the expired-imgs branch February 18, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants