Skip to content

Remove legacy discovery tools list_estimators, search_estimators in favour of new tools query_registry, describe_component#463

Open
Shashankss1205 wants to merge 4 commits into
mainfrom
feature/remove-legacy-discovery-tools
Open

Remove legacy discovery tools list_estimators, search_estimators in favour of new tools query_registry, describe_component#463
Shashankss1205 wants to merge 4 commits into
mainfrom
feature/remove-legacy-discovery-tools

Conversation

@Shashankss1205

@Shashankss1205 Shashankss1205 commented May 30, 2026

Copy link
Copy Markdown
Collaborator

Reference Issues/PRs

Fixes the legacy discovery tool clutter by removing redundant interfaces. fixes #461

What does this implement/fix? Explain your changes.

This pull request completely removes all remaining occurrences and routing of the legacy discovery tools (list_estimators, search_estimators, describe_estimator, and get_available_tags) from both the server routing layer and internal tool implementations.

Specifically:

  • Removed legacy routes from server.py and app.py.
  • Renamed describe_estimator.py to describe_component.py to match the unified describe_component_tool name.
  • Updated all existing unit tests in tests/test_core.py and tests/test_discovery_consolidated.py to verify query_registry_tool and describe_component_tool pagination, task filtering, and boundary validation.
  • Updated user documentation in README.md, docs/source/implementation.md, and docs/source/usage-examples.md.
  • Refactored examples/01_forecasting_workflow.py and examples/02_llm_query_simulation.py to showcase the unified API design.

Does your contribution introduce a new dependency? If yes, which one?

No, this contribution does not introduce any new dependencies.

What should a reviewer concentrate their feedback on?

  • Verify that the query_registry and describe_component routes work perfectly under all conditions.
  • Confirm that no legacy names or modules are imported or used in production pathways.

Any other comments?

The entire codebase is fully formatted and linted via ruff. All 174 test cases pass cleanly under make check.

PR checklist

For all contributions
  • I've added unit tests and made sure they pass locally (make check).
  • I've added the tool to the online documentation in docs/source/.
  • I've updated the existing example scripts or provided a new one to showcase how my tool works in examples/.

@Shashankss1205 Shashankss1205 changed the title Remove legacy discovery tools list_estimators, search_estimators, des… Remove legacy discovery tools list_estimators, search_estimators May 30, 2026
@Shashankss1205 Shashankss1205 mentioned this pull request Jun 1, 2026
8 tasks
@Shashankss1205 Shashankss1205 self-assigned this Jun 1, 2026

@fkiraly fkiraly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks like an improvement.

However, can you please make sure to include docstrings to all important functions and classes? Please have a look how sktime does this. Preferably in the same numpydoc adjacent style that sktime uses.

Otherwise, it becomes really hard to review changes, especially if they are subtle changes.

E.g., I have the question what the new target variable means and which values it can assume, but there is no piece of documentation that would tell me.

@Shashankss1205

Copy link
Copy Markdown
Collaborator Author

@fkiraly thanks for the feedback, I will try updating all of the PRs with the suitable doc strings to let the maintainers understand the pieces of code easily...

@Shashankss1205 Shashankss1205 force-pushed the feature/remove-legacy-discovery-tools branch from 4210aa1 to 398213e Compare June 4, 2026 19:58
@Shashankss1205 Shashankss1205 requested a review from fkiraly June 4, 2026 20:04
…cribe_estimator, get_available_tags in favor of unified query_registry and describe_component everywhere
@Shashankss1205 Shashankss1205 force-pushed the feature/remove-legacy-discovery-tools branch from 58dbd7b to fa67c43 Compare June 7, 2026 10:10
@Shashankss1205 Shashankss1205 changed the title Remove legacy discovery tools list_estimators, search_estimators Remove legacy discovery tools list_estimators, search_estimators in favour of new tools query_registry, describe_component Jun 7, 2026
Add accurate query_registry and describe_component tool schemas in server.py,
document that tag values are typed (not all boolean), and remove the
redundant hyperparameters key from describe_component responses.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Phase 1: Discovery & Registry Tools

3 participants