Remove legacy discovery tools list_estimators, search_estimators in favour of new tools query_registry, describe_component#463
Open
Shashankss1205 wants to merge 4 commits into
Conversation
fkiraly
requested changes
Jun 4, 2026
fkiraly
left a comment
Collaborator
There was a problem hiding this comment.
Overall, this looks like an improvement.
However, can you please make sure to include docstrings to all important functions and classes? Please have a look how sktime does this. Preferably in the same numpydoc adjacent style that sktime uses.
Otherwise, it becomes really hard to review changes, especially if they are subtle changes.
E.g., I have the question what the new target variable means and which values it can assume, but there is no piece of documentation that would tell me.
Collaborator
Author
|
@fkiraly thanks for the feedback, I will try updating all of the PRs with the suitable doc strings to let the maintainers understand the pieces of code easily... |
4210aa1 to
398213e
Compare
…cribe_estimator, get_available_tags in favor of unified query_registry and describe_component everywhere
…r and return schema documentation
58dbd7b to
fa67c43
Compare
Add accurate query_registry and describe_component tool schemas in server.py, document that tag values are typed (not all boolean), and remove the redundant hyperparameters key from describe_component responses. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes the legacy discovery tool clutter by removing redundant interfaces. fixes #461
What does this implement/fix? Explain your changes.
This pull request completely removes all remaining occurrences and routing of the legacy discovery tools (
list_estimators,search_estimators,describe_estimator, andget_available_tags) from both the server routing layer and internal tool implementations.Specifically:
server.pyandapp.py.describe_estimator.pytodescribe_component.pyto match the unifieddescribe_component_toolname.tests/test_core.pyandtests/test_discovery_consolidated.pyto verifyquery_registry_toolanddescribe_component_toolpagination, task filtering, and boundary validation.README.md,docs/source/implementation.md, anddocs/source/usage-examples.md.examples/01_forecasting_workflow.pyandexamples/02_llm_query_simulation.pyto showcase the unified API design.Does your contribution introduce a new dependency? If yes, which one?
No, this contribution does not introduce any new dependencies.
What should a reviewer concentrate their feedback on?
query_registryanddescribe_componentroutes work perfectly under all conditions.Any other comments?
The entire codebase is fully formatted and linted via
ruff. All 174 test cases pass cleanly undermake check.PR checklist
For all contributions
make check).docs/source/.examples/.