FIX: raise error for invalid explicit frequency in data adapters#451
Open
Saloni-0465 wants to merge 1 commit intosktime:mainfrom
Open
FIX: raise error for invalid explicit frequency in data adapters#451Saloni-0465 wants to merge 1 commit intosktime:mainfrom
Saloni-0465 wants to merge 1 commit intosktime:mainfrom
Conversation
Saloni-0465
changed the title
Saloni-0465
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
N/A
What does this implement/fix? Explain your changes.
This PR fixes an issue where invalid explicit frequency values were being silently ignored in the data adapters.
Previously, if a user passed an invalid frequency like frequency="not_a_freq", the error raised by asfreq() was suppressed in both PandasAdapter and FileAdapter, and the data continued loading normally. This made it look like the requested frequency had been applied when it actually hadn’t.
With this change, both adapters now raise a clear ValueError when an invalid explicit frequency is provided. Valid frequency values continue to behave as expected.
Does your contribution introduce a new dependency? If yes, which one?
No.
What should a reviewer concentrate their feedback on?
Whether failing fast is the preferred behavior for invalid explicit frequency config.
Clarity of the error message.
Any other comments?
Validation:
python -m compileall src/sktime_mcp/data/adapters/pandas_adapter.py src/sktime_mcp/data/adapters/file_adapter.py tests/test_data_frequency_validation.py