fix: propagate default target column warnings#443
Open
Saloni-0465 wants to merge 1 commit intosktime:mainfrom
Open
fix: propagate default target column warnings#443Saloni-0465 wants to merge 1 commit intosktime:mainfrom
Saloni-0465 wants to merge 1 commit intosktime:mainfrom
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
N/A
What does this implement/fix? Explain your changes.
This PR ensures that warnings generated during data conversion are surfaced in the top-level validation output.
Previously, if target_column was not provided, to_sktime_format would default to using the first column and store a warning inside the adapter metadata. However, this warning was not included in validation["warnings"], which is what downstream users (including agents) are expected to check.
With this change, any warnings generated during conversion are now propagated to the top-level validation report for both synchronous and asynchronous data loading. This makes the behavior more transparent and easier to debug.
Does your contribution introduce a new dependency? If yes, which one?
No.
What should a reviewer concentrate their feedback on?
executor.pyis appropriateAny other comments?
Added regression tests for sync and async
load_data_sourcewarning propagation.Validation:
python -m compileall src/sktime_mcp/runtime/executor.py tests/test_data_validation_warnings.pyvalidation["warnings"]Note: local
pytestexits with code-1before output in this environment, so I verified behavior directly.PR checklist
For all contributions
For new estimators