Skip to content

[BUG] Classification workflows are discoverable but not executable end-to-end#424

Open
SHIVANSH-ux-ys wants to merge 1 commit intosktime:mainfrom
SHIVANSH-ux-ys:fix-classifiers
Open

[BUG] Classification workflows are discoverable but not executable end-to-end#424
SHIVANSH-ux-ys wants to merge 1 commit intosktime:mainfrom
SHIVANSH-ux-ys:fix-classifiers

Conversation

@SHIVANSH-ux-ys
Copy link
Copy Markdown

Reference Issues/PRs

Fixes #405

What does this implement/fix? Explain your changes.

Currently, agents can successfully discover classification estimators but fail when attempting to execute fit_predict because the executor blindly passes forecasting-specific arguments (like fh) to classifiers.

This PR updates executor.py to check the _estimator_type. If it is a "classifier", it safely routes the fitting and prediction logic to standard (X, y) parameters, omitting the incompatible fh argument.

Does your contribution introduce a new dependency? If yes, which one?

No new dependencies are introduced.

What should a reviewer concentrate their feedback on?

Reviewers can check the fit and predict methods in executor.py to ensure the classification routing logic covers all necessary edge cases.

Any other comments?

This is part of a larger ESoC stability push. I've separated this out into its own focused PR to make review as simple as possible.

PR checklist

  • I have read the CONTRIBUTING guide.
  • I have checked that my PR does not duplicate an existing PR.
  • I have checked that there is an existing issue for this PR, if applicable.
  • My code follows the project's coding standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Classification workflows are discoverable but not executable end-to-end via MCP

1 participant