[BUG] Classification workflows are discoverable but not executable end-to-end#424
Open
SHIVANSH-ux-ys wants to merge 1 commit intosktime:mainfrom
Open
[BUG] Classification workflows are discoverable but not executable end-to-end#424SHIVANSH-ux-ys wants to merge 1 commit intosktime:mainfrom
SHIVANSH-ux-ys wants to merge 1 commit intosktime:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #405
What does this implement/fix? Explain your changes.
Currently, agents can successfully discover classification estimators but fail when attempting to execute
fit_predictbecause the executor blindly passes forecasting-specific arguments (likefh) to classifiers.This PR updates
executor.pyto check the_estimator_type. If it is a"classifier", it safely routes the fitting and prediction logic to standard(X, y)parameters, omitting the incompatiblefhargument.Does your contribution introduce a new dependency? If yes, which one?
No new dependencies are introduced.
What should a reviewer concentrate their feedback on?
Reviewers can check the
fitandpredictmethods inexecutor.pyto ensure the classification routing logic covers all necessary edge cases.Any other comments?
This is part of a larger ESoC stability push. I've separated this out into its own focused PR to make review as simple as possible.
PR checklist