[BUG] Fix server stability: JSON serialization, KeyboardInterrupt, & tool input validations#415
Closed
SHIVANSH-ux-ys wants to merge 4 commits intosktime:mainfrom
Closed
[BUG] Fix server stability: JSON serialization, KeyboardInterrupt, & tool input validations#415SHIVANSH-ux-ys wants to merge 4 commits intosktime:mainfrom
SHIVANSH-ux-ys wants to merge 4 commits intosktime:mainfrom
Conversation
Contributor
|
It looks like some of the issues you worked on already had linked PRs. It might help to check for existing contributions before starting, so effort isn’t duplicated. |
This was referenced May 1, 2026
…, Residuals Tool)
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #401
Fixes #394
Fixes #410
Fixes #373
Fixes #335
Fixes #249
Fixes #407
Fixes #408
Fixes #416 (Note: Overlaps with PR #417 by @biru-codeastromer, happy to defer to their implementation)
Fixes #405
Fixes #400
Fixes #390 (Note: Overlaps with PR #391 by @biru-codeastromer, happy to defer to their implementation)
What does this implement/fix? Explain your changes.
This PR implements a series of critical stability improvements and bug fixes for the
sktime-mcpserver to ensure smoother agentic workflows:pandas.Series.to_dict()leaked non-serializablenumpy.float64values into tool outputs. Implemented type casting to native Pythonfloatinexecutor.pyso standardjson.dumps()works without crashing.Ctrl+C. Wrapped themain()async loop inserver.pywith aKeyboardInterruptcatch for clean exits.mkdocsbuild references fromdev-guide.mdand updated instructions to reflect the new Sphinx/ReadTheDocs pipeline.describe_estimator_toolandsearch_estimators_toolto prevent unhandled exceptions on non-string inputs. Also added positive-integer validation tocleanup_old_jobs_toolto prevent negative inputs from wiping all jobs.describe_estimatorso that LLMs receive the full estimator context for better reasoning.Does your contribution introduce a new dependency? If yes, which one?
No new dependencies are introduced.
What should a reviewer concentrate their feedback on?
Reviewers can verify that the type-casting logic in
executor.pyproperly covers all pandas-to-dict prediction edge cases.Did you add any tests for the change?
No formal pytest cases were added, but local validation scripts were successfully run against
executor.pyandjson.dumpsto verify the serialization fix natively handles all numpy types.6. RangeIndex Formatting Crash (Fixes #390): Fixed an internal crash where
auto_format_on_loadwould fail with an AttributeError when formatting simpleRangeIndexdatasets without a datetime frequency.