fix: add schema constraints to MCP tool definitions#412
Open
Abiram08 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #407
What does this implement/fix? Explain your changes.
Two small schema additions to
server.py:enumto thetaskparameter inlist_estimators— withoutthis, LLM clients have no way to know what values are valid and tend
to guess wrong
minimum: 1andmaximum: 10tocv_foldsinevaluate_estimator— currently nothing stops a client from passing0 or a negative number
Both are missing constraints I noticed while reading through the tool
definitions. Small changes but they make the tools noticeably easier
to use correctly from an LLM client.
Does your contribution introduce a new dependency? If yes, which one?
No.
What should a reviewer concentrate their feedback on?
taskare complete — I basedthem on the sktime docs but may have missed some
cv_foldsor if the upperbound should be higher/removed
Any other comments?
Happy to extend this to other parameters if the approach looks good
to you — there are a few other places where bounds or enums would help.
PR checklist
For all contributions