Skip to content

[ENH] Add warning for multi-target forecasting support in BaseModel #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

PranavBhatP
Copy link
Contributor

Reference Issues/PRs

fixes #1879.

What does this implement/fix? Explain your changes.

Additional warning for missing multi-target support.

PR checklist

  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

Copy link

codecov bot commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@57a6a1c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pytorch_forecasting/models/base/_base_model_v2.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1880   +/-   ##
=======================================
  Coverage        ?   87.78%           
=======================================
  Files           ?       68           
  Lines           ?     6573           
  Branches        ?        0           
=======================================
  Hits            ?     5770           
  Misses          ?      803           
  Partials        ?        0           
Flag Coverage Δ
cpu 87.78% <66.66%> (?)
pytest 87.78% <66.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

@fkiraly fkiraly changed the title [ENH] Add warning for multi-target forecasting support IN BaseModel [ENH] Add warning for multi-target forecasting support in BaseModel Jun 12, 2025
@PranavBhatP PranavBhatP requested a review from fkiraly June 13, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] add warnings to indicate missing multi-target forecasting support in v2 base model.
2 participants