-
Notifications
You must be signed in to change notification settings - Fork 684
[ENH] Implementing D2 data module, tests and TimeXer
model from tslib
for v2
#1836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…nd notebook This change refactors the earlier version of the code, where a list of tensor is returned for multi target datasets. With the v2, a pure tensor is returned for all types of predictions and it moves away from the older, more error prone methof returning list of tensors
Hi, May I suggest all the files refactored for v2 to be kept separate and made private (with an underscore |
I made changes where I could, do lmk if you want other changes. |
…ch-forecasting into tslib-d2-refactor
@phoeenniixx , I have added timexer v2 metadata but it doesn't seem to be running the tests when I try running |
tslib
models.TimeXer
model from tslib
for v2
Description
This PR fixes issue #1833.
This PR involves the following changes:
tslib
- linkTimeXer
with new data module. - linkTslibBaseModel
- link.tslib
data module. - linkChecklist
pre-commit install
.To run hooks independent of commit, execute
pre-commit run --all-files
Make sure to have fun coding!