Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style prop for Avatar #3117

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

phamduylong
Copy link
Contributor

Linked Issue

Closes #3100

Description

Added style prop for Avatar

Bumped Svelte up to 5.18.0 in order to make tests work.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Copy link

changeset-bot bot commented Jan 16, 2025

🦋 Changeset detected

Latest commit: 6f3f4fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@skeletonlabs/skeleton-svelte Patch
@skeletonlabs/skeleton-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ❌ Failed (Inspect) Jan 23, 2025 10:27pm

Copy link

vercel bot commented Jan 16, 2025

@phamduylong is attempting to deploy a commit to the Skeleton Labs Team on Vercel.

A member of the Team first needs to authorize it.

@phamduylong
Copy link
Contributor Author

Bumped svelte up to 5.18, but the eslint version that came with it now broke eslint commands we used before. On the bright side, tests are passing.

@endigo9740
Copy link
Contributor

@phamduylong yeah ESLint recently went through a major update with breaking changes. I've tried a couple times to update it with no avail. If possible we may need to roll that back to the version that was set. I'll have to troubleshoot it when I have more free time.

@phamduylong
Copy link
Contributor Author

@phamduylong yeah ESLint recently went through a major update with breaking changes. I've tried a couple times to update it with no avail. If possible we may need to roll that back to the version that was set. I'll have to troubleshoot it when I have more free time.

Well if nothing broke the lint here then I think it's ready for a pair of eyes

@phamduylong
Copy link
Contributor Author

Rebased. Should be clear to review and merged

.changeset/twelve-pets-hide.md Outdated Show resolved Hide resolved
@endigo9740 endigo9740 merged commit d57f7fa into skeletonlabs:next Jan 23, 2025
4 of 7 checks passed
@phamduylong phamduylong deleted the feat/style-prop-for-avatar branch January 24, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants