Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cli improvements 4 #3110

Merged
merged 10 commits into from
Jan 16, 2025

Conversation

Hugos68
Copy link
Contributor

@Hugos68 Hugos68 commented Jan 15, 2025

Linked Issue

#3090

Description

Adds/Fixes the following:

  • <script> tag transformations are now handled by the same module that handle regular JS/TS files, this is a huge improvement and win.
  • Removed bug where an empty string would crash the tranformSvelte function
  • Remove bug where a long component could cause the invalid renaming of a component
  • Added TabGroup to the list of renamed component, to Tabs.
  • Incredible performance gain (Tests went from 2.3 seconds to 200ms, 10x improvement)
  • All transformations are batched and executed at the end so the migration either is succesful or it isn't, if it's not, nothing will be written to disk.

Copy link

changeset-bot bot commented Jan 15, 2025

🦋 Changeset detected

Latest commit: c491eb5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/skeleton-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ❌ Failed (Inspect) Jan 16, 2025 4:28pm

Copy link

vercel bot commented Jan 15, 2025

@Hugos68 is attempting to deploy a commit to the Skeleton Labs Team on Vercel.

A member of the Team first needs to authorize it.

… write to disk at the end of the migration, this will prevent any files being written to disk if any of the file transformations fail.
… write to disk at the end of the migration, this will prevent any files being written to disk if any of the file transformations fail.
@Hugos68 Hugos68 merged commit 11edc8d into skeletonlabs:next Jan 16, 2025
4 of 7 checks passed
@Hugos68 Hugos68 deleted the feature/cli-improvements-4 branch January 16, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant