-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/Add new Integrations section + Tauri guide #2142
docs/Add new Integrations section + Tauri guide #2142
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Just a suggestion, but maybe to show the logical flow a bit more clearly, have the headers like:
I can see people sort of clicking on the https://tauri.app/v1/guides/getting-started/setup/sveltekit#sveltekit-in-ssg-mode and doing a top down follow of those instructions and having a pure SK and a separate Skeleton install |
@SebasF1349 just did a quick read through. Overall I think this is great. Exactly what I had in mind. That said, here's a few bits of feedback:
<p>
...so we recommend following the <a href="https://tauri.app/v1/guides/getting-started/prerequisites" class="anchor">official Tauri guide</a>
</p>
FYI I'll plan to do a pass through the wording and language a bit when I can. Folks like @Sarenor might be willing to help too! |
@SebasF1349 I've created the repo for the source project: https://github.com/skeletonlabs/skeleton-starter-tauri I've invited you to join this with admin-level access so you have full control. It's set public now. Change whatever you need or what. |
Thanks for your suggestions. I have taken them all into account for this new version. The repo is missing as I still need to add an example on how to communicate the frontend with the backend. |
@SebasF1349 I've pushed my changes. I tried to preserve the overall structure and instruction, while making updates to the text and styling. In most cases I tried to narrow this down to only the most critical information. This tends to lead to the most success when it comes to teaching. There's likely a few typos, but let me know if this works. And of course, please verify that all instructions remain accurate! Overall great job with this, it's brilliant. I can't wait to see what folks build with it! |
@SebasF1349
export const prerender = true
export const ssr = false Does Otherwise it's looking excellent and I like it! |
Description
Added new integrations section and a guide to integrate Skeleton with Tauri.
This is mostly done, but I still want to add a template for people to use so it's not ready to merge. As it's not complete, changeset hasn't been added yet.
Changsets
Instructions: Changesets automate our changelog. If you modify files in
/packages/skeleton
, runpnpm changeset
in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should beminor
while chores and bugfixes should bepatch
. Please prefix the changeset message withfeat:
,bugfix:
orchore:
.Checklist
Please read and apply all contribution requirements.
dev
branch (NEVERmaster
)docs/
,feat/
,chore/
,bugfix/
pnpm check
pnpm format
pnpm test