Small improve #20
Open
Small improve #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the style check complains "WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return".
N-R-K
reviewed
Aug 18, 2022
| else | ||
| options->optarg = 0; | ||
| return option[0]; | ||
| default: { |
Contributor
There was a problem hiding this comment.
it's not possible for optparse_argtype() to return anything other than -1 .. 2, so this case will never execute.
Author
There was a problem hiding this comment.
Logically yes, but I encountered one case that returned 0 from line 263. I will come back to you if I can reproduce the problem.
By the way, isn't it so that optparse should return one of follwing values?
- Option character, when an option is successfully parsed
- -1: indicate all options have been parsed
'?': for invalid option
The return 0 in line 263 doesn't make that much sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.