Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker Compose Files to Support Dynamic Contract ABI Resolution With Skale-Contracts #680

Open
wants to merge 1 commit into
base: 4.1.0
Choose a base branch
from

Conversation

Masterix0
Copy link

Overview

This pull request updates the Docker Compose configurations in node-cli to support the new contract environment variables required for dynamic contract ABI resolution via the skale-contracts library. The changes replace the old approach of downloading large ABI JSON files via URLs with a new method where the contract information is passed directly as environment variables.

Key Changes

  • Environment Variables Update:

    • Introduced new variables MANAGER_CONTRACTS and IMA_CONTRACTS to be forwarded to the services.
  • Docker Compose Updates:

    • Updated docker-compose.yml to export the new contract variables to the relevant services (e.g., skale-admin, skale-api, bounty_agent).
    • Updated docker-compose-sync.yml to similarly export the new variables for sync node services (e.g., skale-sync-admin).
  • Rationale:

    • This change enables dependent services to dynamically resolve contract ABIs using the skale-contracts library.
    • It simplifies configuration by removing the need to download and manage large ABI JSON files.
    • It aligns with our broader strategy for dynamic contract management across the SKALE network.

Impact

  • For Users:

    • Users need to update their environment configurations to use the new variables, aligning with similar changes in node-cli.
    • Legacy configurations using the old ABI URL variables will need to be revised.
  • For Dependent Services:

    • Services such as skale-admin, skale-api, bounty_agent, and skale-sync-admin will now receive the necessary contract information directly from the environment, enabling more dynamic behavior.

Testing

  • All changes have been validated via our unit and integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate skale-contracts library and remove manager and IMA ABIs
1 participant