Update Docker Compose Files to Support Dynamic Contract ABI Resolution With Skale-Contracts #680
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request updates the Docker Compose configurations in node-cli to support the new contract environment variables required for dynamic contract ABI resolution via the skale-contracts library. The changes replace the old approach of downloading large ABI JSON files via URLs with a new method where the contract information is passed directly as environment variables.
Key Changes
Environment Variables Update:
MANAGER_CONTRACTS
andIMA_CONTRACTS
to be forwarded to the services.Docker Compose Updates:
docker-compose.yml
to export the new contract variables to the relevant services (e.g., skale-admin, skale-api, bounty_agent).docker-compose-sync.yml
to similarly export the new variables for sync node services (e.g., skale-sync-admin).Rationale:
Impact
For Users:
For Dependent Services:
Testing