Skip to content

Add config option for verbose isFootgut() logging #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abrossimow wants to merge 1 commit into
base: 1.20
Choose a base branch
from
Open

Add config option for verbose isFootgut() logging #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/java/folk/sisby/tinkerers_smithing/TinkerersSmithingConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,6 @@ public final boolean matchesOrEquivalent(Ingredient fromRepair, Ingredient fromC
}
return transformedJsonString.equals(fromCrafting.toJson().toString());
}
@Comment("Print error messages? (default: false)")
public boolean pronounceUnloadedError = false;
}
11 changes: 7 additions & 4 deletions src/main/java/folk/sisby/tinkerers_smithing/mixin/IngredientMixin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,14 @@
public class IngredientMixin {
@Unique
private boolean isFootgun() {
boolean pronounceUnloadedError = TinkerersSmithing.CONFIG.pronounceUnloadedError;
Ingredient self = (Ingredient) (Object) this;
if (Arrays.stream(self.entries).anyMatch(e -> e instanceof Ingredient.TagEntry) && (Registries.ITEM.getEntryList(ItemTags.PLANKS).isEmpty() || Registries.ITEM.getEntryList(ItemTags.PLANKS).get().size() == 0)) {
TinkerersSmithing.LOGGER.error("[Tinkerer's Smithing] Cowardly refusing to access an unloaded tag ingredient: {}", self.toJson().toString(), new IllegalStateException("A tag ingredient was accessed before tags are loaded - This can break recipes! Report this to the mod in the trace below."));
return true;
}
if (Arrays.stream(self.entries).anyMatch(e -> e instanceof Ingredient.TagEntry) && (Registries.ITEM.getEntryList(ItemTags.PLANKS).isEmpty() || Registries.ITEM.getEntryList(ItemTags.PLANKS).get().size() == 0)) {
if (pronounceUnloadedError) {
TinkerersSmithing.LOGGER.error("[Tinkerer's Smithing] Cowardly refusing to access an unloaded tag ingredient: {}", self.toJson().toString(), new IllegalStateException("A tag ingredient was accessed before tags are loaded - This can break recipes! Report this to the mod in the trace below."));
}
return true;
}
return false;
}

Expand Down