Skip to content

Conversation

@murphy-slaw
Copy link

@murphy-slaw murphy-slaw commented Nov 19, 2024

KubeJS is naughty and mucks around in Recipe Manager in an incompatible way, as documented in
#40
This PR implements the suggested workaround from here:
KubeJS-Mods/KubeJS#822

tl;dr

  • adds a mixin plugin to conditionally load the RecipeManager mixin only if KubeJS is not present.
  • adds a kubejs plugin to load the recipes if KubeJS is present.

It's annoying to have to do this but I figure that some folks might find the workaround useful.

@sisby-folk
Copy link
Owner

Yeah for the reasons you've already stated we feel it wrong to explicitly depend on a mod just because it misbehaves,

but we'll approve the build and leave this up and anyone who needs this can come grab it.

@murphy-slaw
Copy link
Author

That makes sense.

@murphy-slaw
Copy link
Author

An update:

I realized that I could build this completely outside of the TS codebase and deliver a separate mod that only has the KubeJS plugin in it. The result is this:

https://github.com/murphy-slaw/tinkerers_kubejs_plugin

I was planning on publishing it on Modrinth if you have no objections.

@sisby-folk
Copy link
Owner

go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants