-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #1272 #1273
base: master
Are you sure you want to change the base?
fix #1272 #1273
Conversation
logger_test.go
Outdated
for { | ||
func() { | ||
defer func() { | ||
// 处理所有异常,防止panic导致程序关闭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this comment says?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sry I have deleted unnecessary Chinese comments
logger_test.go
Outdated
return []byte(msg), nil | ||
} | ||
|
||
// 获取当前协程id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have deleted unnecessary Chinese comments
Remove unnecessary comments
Remove unnecessary comments
Thanks for your contribution, but we already have the |
|
I replace the implementation |
…instant.If a new hook is added, the hook may not be triggered
I found another problem . Replication can indeed improve performance, but it will lead to this instant.
|
#1272