Improving syslog hook #1225
Open
Improving syslog hook #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…server is down, writing does not degrade if syslog server is slow.
dgsb
reviewed
Feb 19, 2021
| @@ -4,50 +4,96 @@ package syslog | |||
|
|
|||
| import ( | |||
| "fmt" | |||
| "log/syslog" | |||
| //"log/syslog" | |||
| "github.com/GolangResources/syslog/syslog" | |||
There was a problem hiding this comment.
What does this package brings to the standard library one ?
| w, err := syslog.Dial(network, raddr, priority, tag) | ||
| return &SyslogHook{w, network, raddr}, err | ||
| func NewSyslogHook(network, raddr string, priority sg.Priority, tag string) (*SyslogHook, error) { | ||
| w, err := syslog.Dial("ctcp" , raddr, priority, nil) |
| network, | ||
| raddr, | ||
| tag, | ||
| make(chan *SEntry, CHANNEL_DEPTH), |
There was a problem hiding this comment.
Could the channel creation be configurable ?
We need to be able to keep a compatible behaviour with the former version.
| make(chan *SEntry, CHANNEL_DEPTH), | ||
| } | ||
| for i := 0; i <= NUM_SYSLOG_WORKERS; i++ { | ||
| go hook.worker(i) |
There was a problem hiding this comment.
We need to be able to stop the started go routine and to wait for them.
| tag, | ||
| make(chan *SEntry, CHANNEL_DEPTH), | ||
| } | ||
| for i := 0; i <= NUM_SYSLOG_WORKERS; i++ { |
There was a problem hiding this comment.
Same here we need this hook to be configurable so that we can keep the former behaviour.
|
|
||
| func (hook *SyslogHook) worker(i int) { | ||
| for entry := range hook.syschan { | ||
| time.Sleep(1) |
| func (hook *SyslogHook) worker(i int) { | ||
| for entry := range hook.syschan { | ||
| time.Sleep(1) | ||
| func() error { |
There was a problem hiding this comment.
What is the purpose of the closure ?
|
hello @aluvare thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syslog library has been changed to prevent crashes if the syslog server is down, writes doesnt degrade if syslog server is slow.