Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistent levels when creating Entry from Logger issue #1163

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix inconsistent levels when creating Entry from Logger issue #1163

wants to merge 2 commits into from

Conversation

hcmlinj
Copy link

@hcmlinj hcmlinj commented Aug 13, 2020 •
edited
Loading

Fixes #1158

  1. Fix inconsistent levels when creating Entry from Logger issue.
  2. Add TestLevel unit test.
  3. Fix TestFormatting unit test.

David Bariod and others added 2 commits August 13, 2020 18:21
@hcmlinj hcmlinj changed the title Fix inconsistent levels when creating Entry from Logger issue #1158 Fix inconsistent levels when creating Entry from Logger issue Aug 13, 2020
@hcmlinj
Copy link
Author

hcmlinj commented Sep 10, 2020

Dear @markphelps , do you mind review this PR or give some suggestion?

@hcmlinj
Copy link
Author

hcmlinj commented Sep 21, 2020

Dear @dgsb, do you mind review this PR or give some suggestion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Inconsistent levels when creating Entry from Logger
1 participant
@hcmlinj