feat: throw when trying to use .value() on a method #2631
+39
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents an error when running puppeteer/chrome on latest Ubuntu See: - https://github.com/sinonjs/sinon/actions/runs/12502499977/job/34881594651?pr=2631 - puppeteer/puppeteer#13365
|
@mantoni the errors seen in 
If you're seeing similar errors in Mochify, you might want to stick to |
fatso83
reviewed
Dec 30, 2024
|
|
||
| if (propertyIsMethod) { | ||
| throw new Error( | ||
| `${rootStub.propName} is a function, not a getter or value. Use .returns() instead of .value()`, |
There was a problem hiding this comment.
Are we supposed to allow setting .value() on a getter property? Seems erronous.
fatso83
reviewed
Dec 30, 2024
Comment on lines
+3784
to
+3793
| it("allows stubbing getters", function () { | ||
| const y = { | ||
| get foo() { | ||
| return "bar"; | ||
| }, | ||
| }; | ||
| refute.exception(function () { | ||
| createStub(y, "foo").value("bar"); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
The original issue (#2629) does not deal with this issue, so this seems more like we are documenting existing (non-intentional) behavior? Dan does talk about getters, but that is the conventional Java-bean like getters, which are methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
This is a solution for #2629
See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/getOwnPropertyDescriptor#get for the
.getproperty on the property descriptor.How to verify - mandatory
npm installnpm testChecklist for author
npm run lintpasses