Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python/r] Docstring audit for new shape #3399

Merged
merged 7 commits into from
Dec 5, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Dec 4, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048]. See also #3282.

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

Notes for Reviewer:

I also found some missing symlinks in doc/source/notebooks.

@johnkerl johnkerl force-pushed the kerl/new-shape-more-docstrings branch 2 times, most recently from b307c7a to cdc4a9a Compare December 4, 2024 21:06
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.91%. Comparing base (0ce5ac9) to head (bffc11c).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3399      +/-   ##
==========================================
+ Coverage   85.85%   85.91%   +0.06%     
==========================================
  Files          55       55              
  Lines        6199     6192       -7     
==========================================
- Hits         5322     5320       -2     
+ Misses        877      872       -5     
Flag Coverage Δ
python 85.91% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 85.91% <100.00%> (+0.06%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl force-pushed the kerl/new-shape-more-docstrings branch from cdc4a9a to da2c001 Compare December 4, 2024 21:59
Copy link
Member

@mojaveazure mojaveazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the R side

@johnkerl johnkerl merged commit ff8c19d into main Dec 5, 2024
15 checks passed
@johnkerl johnkerl deleted the kerl/new-shape-more-docstrings branch December 5, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants