Skip to content

Commit

Permalink
code-review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
johnkerl committed Dec 4, 2024
1 parent 53f053e commit c3cf16f
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
4 changes: 3 additions & 1 deletion apis/python/notebooks/tutorial_soma_shape.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@
"\n",
"In this notebook, we'll go through how you use shapes for the dataframes and arrays within your SOMA experiments, when and how you can resize, and options for experiments created before TileDB-SOMA 1.15.\n",
"\n",
"The dataset used is from Peripheral Blood Mononuclear Cells (PBMC), which is freely available from 10X Genomics. "
"The dataset used is from Peripheral Blood Mononuclear Cells (PBMC), which is freely available from 10X Genomics.\n",
"\n",
"(Please also see the [Academy tutorial](https://cloud.tiledb.com/academy/structure/life-sciences/single-cell/tutorials/shapes/).)"
]
},
{
Expand Down
10 changes: 8 additions & 2 deletions apis/r/vignettes/soma-shapes.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ knitr::opts_chunk$set(

As of TileDB-SOMA 1.15 we're proud to support a more intuitive and extensible notion of shape.

Please also see the [Academy tutorial](https://cloud.tiledb.com/academy/structure/life-sciences/single-cell/tutorials/shapes/).

## Example data

Let's load the bundled `SOMAExperiment` containing a subsetted version of the 10X genomics [PBMC dataset](https://satijalab.github.io/seurat-object/reference/pbmc_small.html) provided by SeuratObject. This will return a `SOMAExperiment` object.
Expand Down Expand Up @@ -191,11 +193,15 @@ Here we see the `soma_joinid` slot of the dataframe's domain is as requested.

Another point is that domain cannot be specified for string-type index columns. You can set them at create one of two ways:

`domain = list(soma_joinid = (0, 9), mystring = NULL)`
```{r, eval=FALSE}
domain = list(soma_joinid = (0, 9), mystring = NULL)
```

or

`domain = list(soma_joinid = (0, 9), mystring = c('', ''))`
```{r, eval=FALSE}
domain = list(soma_joinid = (0, 9), mystring = c('', ''))
```

and in either case the domain slot for a string-typed index column will read back as `('', '')`.

Expand Down

0 comments on commit c3cf16f

Please sign in to comment.