[r] Address two more compiler warnings (#3320)

* [r] Two more compile-time warnings * code-review feedback [skip ci] Co-authored-by: Julia Dark <[email protected]> --------- Co-authored-by: Julia Dark <[email protected]>
single-cell-data · Nov 13, 2024 · 2ae3c6d · 2ae3c6d
1 parent d0cbd2d
commit 2ae3c6d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/apis/r/src/rinterface.cpp b/apis/r/src/rinterface.cpp
@@ -404,7 +404,7 @@ SEXP c_schema(const std::string& uri, Rcpp::XPtr<somactx_wrap_t> ctxxp) {
         ArrowSchemaAllocateChildren(sch, lib_retval->n_children),
         "Bad schema children alloc");
 
-    for (size_t i = 0; i < lib_retval->n_children; i++) {
+    for (size_t i = 0; i < static_cast<size_t>(lib_retval->n_children); i++) {
         spdl::info(
             "[c_schema] Accessing name '{}' format '{}' at position {}",
             std::string(lib_retval->children[i]->name),

diff --git a/apis/r/src/rutilities.cpp b/apis/r/src/rutilities.cpp
@@ -468,7 +468,7 @@ SEXP convert_domainish(const tdbs::ArrowTable& arrow_table) {
         ArrowArrayAllocateChildren(arr, arrow_array->n_children),
         "Bad array children alloc");
 
-    for (size_t i = 0; i < ncol; i++) {
+    for (size_t i = 0; i < static_cast<size_t>(ncol); i++) {
         if (arrow_array->children[i]->n_buffers == 3) {
             // Arrow semantics: variable-length: buffers 0,1,2 are validity,
             // offsets, data

diff --git a/libtiledbsoma/test/common.cc b/libtiledbsoma/test/common.cc
@@ -145,15 +145,15 @@ std::unique_ptr<ArrowSchema> create_index_cols_info_schema(
     std::vector<std::string> names(ndim);
     std::vector<tiledb_datatype_t> tiledb_datatypes(ndim);
 
-    for (int i = 0; i < (int)ndim; i++) {
+    for (int i = 0; i < static_cast<int>(ndim); i++) {
         const DimInfo& dim_info = dim_infos[i];
         names[i] = dim_info.name;
         tiledb_datatypes[i] = dim_info.tiledb_datatype;
     }
 
     auto schema = ArrowAdapter::make_arrow_schema(names, tiledb_datatypes);
 
-    for (size_t i = 0; i < (size_t)schema->n_children; ++i) {
+    for (size_t i = 0; i < static_cast<size_t>(schema->n_children); ++i) {
         if (strcmp(schema->children[i]->name, "soma_geometry")) {
             nanoarrow::UniqueBuffer buffer;
             ArrowMetadataBuilderInit(buffer.get(), nullptr);